264842 - Match Case option on find toolbar has no effect on Highlighting

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Bill Gianopoulos [:WG9s]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0

The Match case option on the Find Toolbar appears to work correctly for Finding
text, but not for hightlighting.  Highlighting appears to always be
case-insensitive.  This is not very intuitive.

Reproducible: Always
Steps to Reproduce:
1.  visit http://www.mozilla.org
2.  press ctrl-f
3.  enter the text mozilla in the findbar
4.  select Match case
5.  select Highlight
Actual Results:  
All occurances of either "mozilla" or "Mozilla" are hightlighted.

Expected Results:  
Only occurances of "mozzilla" should have been highlighted.  "Mozilla" should
NOT be highlighted.

Comment 1

[Dave Wolovich]

I can reproduce this bug everytime.  Case is definitely being ignored.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0

Comment 2

[sairuh (rarely reading bugmail)]

nominating, in case the fix for this would be easy and unlikely to cause
regressions (minus otherwise).

Comment 3

[Blake Ross]

Fixed.

Comment 4

[Bill Gianopoulos [:WG9s]]

There is still on minor nit with this fix installed.  If you enter the find
string and then select Highlight, so that the matches are now highlighted,
toggling the Match case checkbox does not change the highlighting.  Toggling the
match case checkbox if the hightlight button is already selected and the find
text is not null needs to trigger a redo of the highlighting.  If you think this
should be a seperate bug I will file one.

Comment 5

[Michael Clackler]

Attachment: patch to reset highlighted text on match case change

This patch fixes the problem described in comment #4.  If there is a change in
the match case setting and there is text highlighted, the highlighted text is
cleared and re-highlighted to ensure the highlighted text matches the match
case state.

Comment 6

[Grégoire Welraeds]

Comment #4 is still not fixed in FF 1.0 RC 2.

Comment 7

[Albert Strasheim]

The issue with highlighting not changing with Match case is still there in
Firefox 1.0.

Comment 8

[Tracy Walker [:tracy]]

This bug as summarized is fixed in 1.0.  However, the dynamic changing of match
case does not work.  From what I can tell, the patch in comment #5 was never
approved/checked in. To stop some of the confusion here, I'll make that a new
bug and mark this one fixed.  

Comment 9

[Tracy Walker [:tracy]]

created bug 273149 for the dynamic change issue.