Closed
Bug 264861
Opened 20 years ago
Closed 20 years ago
find button broken in Help
Categories
(SeaMonkey :: Help Viewer, defect)
SeaMonkey
Help Viewer
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
Details
(Keywords: fixed-aviary1.0, regression)
Attachments
(1 file)
905 bytes,
patch
|
Details | Diff | Splinter Review |
The Help Viewer provides a find button, which can be added to the Help Viewer
toolbar using Customize Toolbar.
Click the Find button.
Actual result: Nothing happens.
Expected result: The find bar should be opened (if it's not open already) and
the searchbox focussed.
This is a regression from Blake's find toolbar landing 2004-10-15 23:24, where
he renamed the respective command id from
<command id="Help:Find" oncommand="helpBrowser.find();"/>
to
<command id="cmd_find" oncommand="onFindCmd();"/>
without changing it here:
<toolbarbutton id="help-find-button"
command="cmd_find"/>
Assignee | ||
Comment 1•20 years ago
|
||
Fixes the button.
This is the only place left where Help:Find is used:
http://lxr.mozilla.org/aviarybranch/search?string=Help%3AFind
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 162458 [details] [diff] [review]
patch
Blake, this is your regression. One-line fix.
Attachment #162458 -
Flags: review?(firefox)
Attachment #162458 -
Flags: approval-aviary?
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0?
Whiteboard: [have patch] - need review blake
Target Milestone: --- → Firefox1.0
Comment 3•20 years ago
|
||
Comment on attachment 162458 [details] [diff] [review]
patch
a=asa pending review.
Attachment #162458 -
Flags: approval-aviary? → approval-aviary+
Comment 4•20 years ago
|
||
Comment on attachment 162458 [details] [diff] [review]
patch
land now, now!
Attachment #162458 -
Flags: review?(firefox) → review+
Assignee | ||
Comment 5•20 years ago
|
||
Checked into branch. Trunk isn't affected.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch] - need review blake
Comment 6•20 years ago
|
||
Verified with windows branch build 2004-10-19-07-0.9
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Flags: review+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0 → ---
Version: 1.0 Branch → unspecified
Updated•18 years ago
|
Flags: in-testsuite?
Updated•9 years ago
|
Product: Toolkit → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•