Closed Bug 264861 Opened 20 years ago Closed 20 years ago

find button broken in Help

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

(Keywords: fixed-aviary1.0, regression)

Attachments

(1 file)

The Help Viewer provides a find button, which can be added to the Help Viewer toolbar using Customize Toolbar. Click the Find button. Actual result: Nothing happens. Expected result: The find bar should be opened (if it's not open already) and the searchbox focussed. This is a regression from Blake's find toolbar landing 2004-10-15 23:24, where he renamed the respective command id from <command id="Help:Find" oncommand="helpBrowser.find();"/> to <command id="cmd_find" oncommand="onFindCmd();"/> without changing it here: <toolbarbutton id="help-find-button" command="cmd_find"/>
Attached patch patchSplinter Review
Fixes the button. This is the only place left where Help:Find is used: http://lxr.mozilla.org/aviarybranch/search?string=Help%3AFind
Comment on attachment 162458 [details] [diff] [review] patch Blake, this is your regression. One-line fix.
Attachment #162458 - Flags: review?(firefox)
Attachment #162458 - Flags: approval-aviary?
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0?
Whiteboard: [have patch] - need review blake
Target Milestone: --- → Firefox1.0
Comment on attachment 162458 [details] [diff] [review] patch a=asa pending review.
Attachment #162458 - Flags: approval-aviary? → approval-aviary+
Comment on attachment 162458 [details] [diff] [review] patch land now, now!
Attachment #162458 - Flags: review?(firefox) → review+
Checked into branch. Trunk isn't affected.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch] - need review blake
Verified with windows branch build 2004-10-19-07-0.9
Status: RESOLVED → VERIFIED
Flags: review+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0 → ---
Version: 1.0 Branch → unspecified
Flags: in-testsuite?
The find button is gone.
Flags: in-testsuite? → in-testsuite-
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: