264861 - find button broken in Help

Status: VERIFIED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Steffen Wilberg]

The Help Viewer provides a find button, which can be added to the Help Viewer
toolbar using Customize Toolbar.

Click the Find button.
Actual result: Nothing happens.

Expected result: The find bar should be opened (if it's not open already) and
the searchbox focussed.

This is a regression from Blake's find toolbar landing 2004-10-15 23:24, where
he renamed the respective command id from
   <command id="Help:Find" oncommand="helpBrowser.find();"/>
to
   <command id="cmd_find" oncommand="onFindCmd();"/>

without changing it here:
   <toolbarbutton id="help-find-button"
                  command="cmd_find"/>

Comment 1

[Steffen Wilberg]

Attachment: patch

Fixes the button.
This is the only place left where Help:Find is used:
http://lxr.mozilla.org/aviarybranch/search?string=Help%3AFind

Comment 2

[Steffen Wilberg]

Comment on attachment 162458 [details] [diff] [review]
patch

Blake, this is your regression. One-line fix.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 162458 [details] [diff] [review]
patch

a=asa pending review.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 162458 [details] [diff] [review]
patch

land now, now!

Comment 5

[Steffen Wilberg]

Checked into branch. Trunk isn't affected.

Comment 6

[Tracy Walker [:tracy]]

Verified with windows branch build 2004-10-19-07-0.9

Comment 7

[Steffen Wilberg]

The find button is gone.