264906 - Various appmgr issues

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: Patch

1. Preview is not spelled Preivew
2. Sort the applications properly
3. Rather than generating the string to display, just show the whole Version
field
4. Allow updates to all fields.  This may alternately be done by only letting
the user change the Version field, and regenerating major/minor/release/subver
form the Version - I'm not sure what is ideal.	Right now you still can't
update the Version field.
5. "" is a valid SubVer

Comment 2

[Wolf [:wolf]]

Moving bug to webtools/update, since there's an attached patch. (There's review
flags here :-) if you need to request such things. ;-) ).

Comment 3

[alanjstr]

Don't forget a way to do RC1, A1, A2 ... although those might fall under the
Build Version dropdown.  However, we need a way to make sure they sort properly,
and the current GUI doesn't allow an internal version of 0.95, 0.96 or whatever
method we use.

Comment 4

[Wolf [:wolf]]

I'll get to those when I update app. manager to be current code compliant. :-)
A sort key would be the easiest way to force the sorting to be correct.
Per-Application of course.

Now to review that patch...

Comment 5

[Wolf [:wolf]]

Comment on attachment 162479 [details] [diff] [review]
Patch

Looks good to me. It does fix the obvious breakage.
 It certainly doesn't bring app manager anywhere close to "done", but it wasn't
intended to. Thanks for fixing that typo on inc_footer. ;-)

r=me.

I'll check this in shortly.

Comment 6

[Wolf [:wolf]]

Patch checked in. Leaving bug open since there'll probably be more stuff for
appmanager that this covers. :-)

Comment 7

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)