Closed Bug 264938 Opened 20 years ago Closed 20 years ago

Collapse toolbar button shouldn't hide the statusbar

Categories

(Core Graveyard :: Widget: Mac, enhancement)

Product:
Core Graveyard
Component:
Widget: Mac
Platform:
PowerPC
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.8alpha6

People

(Reporter: asaf, Assigned: asaf)

Details

Attachments

(1 file)

don't hide statusbar
1.37 KB, patch
jhpedemonte
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review
The current impl' hidee the whole toolbox, we likely want to hide the first childnode only (ignoring the menubar); the expected behavior is to hide the toolbar only (which is the first childnode most of the times). See main browser window and js console for real-life examples.
but we get dinged in camino for only hiding the toolbar, not the bookmark bar.
Assignee: jag → sfraser_bugs
Component: XP Toolkit/Widgets → Widget: Mac
QA Contact: jrgmorrison
We'll discuss personal bar later, we should fix the obvious ones at first. Changing summary
Summary: Change collapse toolbar button behavior to hide toolbox's first childnode only → Collapse toolbar button shouldn't hide tabbrowser and statusbar
We all agree about this one, right? ;)
Attachment #171411 - Flags: superreview?(sfraser_bugs)
Attachment #171411 - Flags: review?(pinkerton)
Will also affect popup windows that web pages create with special chrome flags?
(In reply to comment #4) > Will also affect popup windows that web pages create with special chrome flags? no, they're not handled by Toolbar()
Comment on attachment 171411 [details] [diff] [review] don't hide statusbar Seems fine.
Attachment #171411 - Flags: superreview?(sfraser_bugs) → superreview+
well, we already have bug(s) opened for the tabbrowser part.
Summary: Collapse toolbar button shouldn't hide tabbrowser and statusbar → Collapse toolbar button shouldn't hide the statusbar
Assignee: sfraser_bugs → bugs.mano
Attachment #171411 - Flags: review?(pinkerton) → review+
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha6
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: