264978 - Name should not be editable when read from install.rdf

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

If install.rdf is read and parsed to get compatibility, then the Name box should
not be editable.  This box should only be editable if there was no install.rdf
found.  Name comes from install.rdf, so if they want to change it, that is where
it should be changed.

Comment 1

[Wolf [:wolf]]

Name isn't a required static value. Extensions *can* change names and keep the
same GUID. It's the GUID that's checked against, not the name.

Therefore, it's auto-filled in as a courtesy. There's no logical reason to block
the editing of that field, when adding a new version with a different name will
change the old versions names anyway. :-)

Comment 2

[alanjstr]

There is a difference.  This will force them to change the name in the
install.rdf.  Otherwise when someone installs an extension, it won't necessarily
match the name of what they downloaded.  Someone could install "I am great" and
wind up with a listing for "I suck".  Can you at least think about it for a while?

Comment 3

[Wolf [:wolf]]

For old versions only. For a new version with a new name, they should match..
I'll verify that the auto-fill-in for extensions w/ a t_main record pulls it
from install.rdf and not the DB though. but it's not likely that box will become
non-editable. It just doesn't make sense to when the same functionality is
available from the edit page and that's not going to change.

Comment 4

[Wolf [:wolf]]

The $name is pulled from the install.rdf in all cases. If there's not an
install.rdf it'll simply be blank. (or if it's update mode, filled in for
convienience).