264983 - <tabbox> and tabs have no ID for use by overlays

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P5)

Description

[Stephen Oberholtzer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

Without an excessive amount of javascript+DOM magic, overlays need elements with
IDs to bind to. However, the 'bookmark properties' dialog's <tabbox> and
<tabpanels> elements have no ID for extensions to bind to, in order to enhance
the bookmark properties dialog.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Strangely enough, there are two tabs with IDs, 'ScheduleTab' and 'NotifyTab',
that don't seem to actually exist in FF.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> Strangely enough, there are two tabs with IDs, 'ScheduleTab' and 'NotifyTab',
> that don't seem to actually exist in FF.

Those tabs were hidden for Firefox 1.0 because the feature was buggy. See bug
253478.

What exactly would be needed here as far as IDs? Just the <tabbox> and <tabpanel>?

http://lxr.mozilla.org/mozilla/source/browser/components/bookmarks/content/bookmarksProperties.xul#56

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch v1

Add the IDs.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 174195 [details] [diff] [review]
Patch v1

r=vladimir

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch v1 (Checked in)

Comment 5

[Ian Neal]

Comment on attachment 175608 [details] [diff] [review]
Patch v1 (Checked in)

Checking in bookmarksProperties.xul;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksProperties.xul,v
 <--  bookmarksProperties.xul
new revision: 1.10; previous revision: 1.9
done

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change