265201 - Error when adding a new property to not extensible object should refer to the object.

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P5)

Description

[timeless]

R:\mozilla\js\src\WINNT5.1_DBG.OBJ>js -w -s
js> var testc={}; seal(testc); testc.ase=true;
1: Error: testc.ase is read-only
js> build();help()
built on Jul 18 2004 at 17:51:08
JavaScript-C 1.5 pre-release 6a 2004-06-09

it seems to me that something that doesn't exist can't be readonly.

instead of:
1: Error: testc.ase is read-only

i'd expect something closer to this:
js> Components.z=1
typein:3: uncaught exception: [Exception... "Cannot modify properties of a
WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)" 
location: "JS frame :: typein :: <TOP_LEVEL> :: line 3"  data: no]

simply:
1: Error: testc is read-only
or
1: Error: Can't modify properties of a readonly object (testc).

Comment 1

[Bob Clary [:bc] (inactive)]

-> default qa

Comment 2

[Brendan Eich [:brendan]]

I thought pschwartau reported this earlier, right after JS_SealObject went in.

/be

Comment 3

[Tom S. (please needinfo tschuster)]

The seal api doesn't exists anymore, but when adding properties to not extensible object, we still get a rather obscure message.

function () {
   'use strict'; 
   var o = {}
   Object.seal(o);
   o.a = 1;
}
Error message is: o.a is not extensible
We should change this to 'o is not extensible, can't add new property'

Changed title to reflect new content.

Comment 4

[Tom S. (please needinfo tschuster)]

Now gives:
>Exception: ({}) is not extensible

Comment 5

[Tom S. (please needinfo tschuster)]

Nowadays: "TypeError: can't define property "a": Object is not extensible"

Comment 6

[Tooru Fujisawa [:arai]]

are we going to put the disassemble or toString of the object into the error message?
if not, the current message seems to be sufficient and we can close this.

Comment 7

[André Bargull [:anba]]

Let's resolve this as WFM per comment #6.