265208 - Context menu doesn't close when opening modal dialog from sub-menu

Status: RESOLVED DUPLICATE of bug 262031

(Core :: XUL, defect)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041018 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041018 Firefox/0.9.1+

This is a spin-off of bug 137696 and a regression from fixing bug 160454.

Reproducible: Always
Steps to Reproduce:
1. Right click in a frame on a site which has frames
2. Choose This Frame -> Save Frame As
3.

Actual Results:  
The right click menu popup stays open.

Expected Results:  
It should have closed.

Comment 1

[Martijn Wargers (dead)]

(Only happens in Mozilla builds after 2004-10-10, not in Firefox)

Comment 2

[Boris Zbarsky [:bzbarsky]]

We probably want to do the actual save off a timeout so the menu can close...
alternately, the menu should call us off a timeout so it can close.

I guess the latter is a better idea.  biesi?  Neil?  Thoughts?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #2)
> alternately, the menu should call us off a timeout so it can close.

do any handlers want to keep the menu open?

Comment 4

[Boris Zbarsky [:bzbarsky]]

You mean does the context menu ever want to trigger things that will leave it
open while they happen?  No.

Comment 5

[[e-mail]]

I don't see this in Linux, so is something Windows-specific messing this up?

Comment 6

[Boris Zbarsky [:bzbarsky]]

I think the Linux widget code is more aggressive about taking down popups or
something....

Comment 7

[[e-mail]]

Hmm... about:config's New->(type) is doing this for me too...

Comment 8

[Stefan A. Möller]

I'm not sure if this bug really is related to the process of saving files (bug
160454). More likely it happens whenever *any* modal(!) dialog is opened from a
context menu's submenu. (Comment #5: The "Save As" dialog is not modal in Linux?)

Example:
I've got Linky installed, which adds another submenu to the context menu. If you
select "Open All Links ..." from the Linky submenu it will open a modal dialog
(if not, force it by holding shift simultaneously or change the Linky
preferences). In that case the context menu remains open, too. 
Then I've modified the Linky code to open a JavaScript alert (modal, too)
whenever I click onto any Linky submenu entry --> same result: alert opens and
context menu stays on top.

By the way:
If you close one of those menu leftovers by means of pressing ESC, the said
submenu completely vanishes from the context menu. You have to restart Mozilla
to get it back.
Steps to reproduce that:
1. Right click in a frame on a site which has frames
2. Choose This Frame -> Save Frame As
3. Give focus to menu leftover by clicking onto one of its separator lines
4. Press ESC to close the menu
5. Cancel the file picker
6. Right click in the frame again
7. Choose This Frame -> ... now the submenu is missing!

Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.8a6) Gecko/20050111

Comment 9

[irongut]

*** Bug 286775 has been marked as a duplicate of this bug. ***

Comment 10

[irongut]

Confirmed
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050328

WFM
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050317
Firefox/1.0.2

Not related to file handling, this happens for any modal dialog opened from a
sub-menu of a context menu. e.g. Mail+News message pane context menu, Mark, As
Read by Date..

Changing Component to XP Toolkit/Widgets: Menus

Changing summary from:
Right click This Frame -> Save Frame As lets the menu popup open, when it should
close
To: Context menu doesn't close when opening modal dialog from sub-menu

Comment 11

[irongut]

*** Bug 273294 has been marked as a duplicate of this bug. ***

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> (Only happens in Mozilla builds after 2004-10-10, not in Firefox)

Martijn, could you check again the date(s) ?

because,
Quoted from (MozillaAS) bug 286775 comment 2
{{
Well, this is a regression, but i have no good regression timeframe. This
regressed somewhere between 2004-07-12-14 and 2004-08-19-08 :/ (between those
two builds i couldn't find any build on archive.m.o)
}}

Comment 13

[Martijn Wargers (dead)]

Again, I get the same observation. Works in 2004-10-09 build, fails in
2004-10-10 build.

Comment 14

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

*** Bug 286775 has been marked as a duplicate of this bug. ***

Comment 15

[Jed B]

This should be a blocker for Firefox 1.1, as not only does it break a lot of
extensions, it is very anoying behavior. (Try navigating the bookmarks)

Comment 16

[Boris Zbarsky [:bzbarsky]]

How does this break extensions?

And if you want this fixed for anything but the save as case in Seamonkey (which
is what the bug is originally filed on), it's assigned to the wrong person. 
Note also comment 1, if you please.

Comment 17

[Jed B]

Thanks Boris.

However this also happens in about:config for me on the latest Firefox
nightlies. (WinXP Pro)

It breaks extensions in the way if any extension that adds entries to the
context menu, when clicking on an item (say one item has the following
oncommand="doSomething();" which opens an XUL window, prompt, whatever), 
the code is executed and the context menu stays open.

Countless extensions use the contextmenu for opening windows, prompts, whathave you.

Should I file a new bug?

Comment 18

[Boris Zbarsky [:bzbarsky]]

Jed, no.  You should look at the "depends on" field of this bug.  Or something.

Comment 19

[irongut]

WFM
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521

I checked Save Frame As, As Read By Date (Mail) and about:config.

Looks like recent resolution of bug 262031 fixed this one.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Yeah

*** This bug has been marked as a duplicate of 262031 ***