265223 - Firefox build instructions says optimized non-debug is default when it's not

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0

The URL given contains the following text:

Optimized or Debug?

Optimized is best if you plan on using the build you create for all your
browsing), Debug is best if you want to fix bugs. Builds are optimized by default. 
----

But builds are debug and unoptimized by default on win32 (and presumably other
platforms). Using mozilla/browser/config/mozconfig I get the following
about:buildconfig using Visual Studio 6:

Build platform target i686-pc-cygwin

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TC -nologo -W3 -nologo -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TP -nologo -W3 -nologo -Gy -Fd$(PDBFILE)

Configure arguments
--disable-ldap --disable-mailnews
--enable-extensions=cookie,xml-rpc,xmlextras,pref,transformiix,universalchardet,webservices,inspector,gnomevfs,negotiateauth
--enable-crypto --disable-composer --enable-single-profile --disable-profilesharing


i.e. --disable-debug and -enable-optimize are missing. The build also spits out
debug information to the console, and the dist/bin directory is some 42 MB in
size instead of 15 MB.

It would be great if this could be fixed before 1.0 hits the wire. The error
occurs twice on the page.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Steffen, could you look into this since you are the most recent modifier of the
page concerned ?

Comment 2

[Steffen Wilberg]

Confirming.
On the aviary branch, the default is debug and non-optimized:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/configure.in&rev=1.1335.2.6.2.14&mark=4216-4221,4247-4249,4267-4270#4216
If you don't like that, you have to specify --disable-debug and --enable-optimize.

On the trunk, the default is non-debug and optimized:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/configure.in&rev=1.1375&mark=4450-4453,4478-4481,4499-4501#4450
If you don't like that, you have to specify --enable-debug and --disable-optimize.

I just added a comment to bug 54828, which changed the default on the trunk.

Comment 3

[Benjamin Smedberg]

Hrmn, I'm updating www.mozilla.org/build to have build instructions for all the
apps, we might just want a redirect.

Comment 4

[Steffen Wilberg]

The default won't change on the branch, see bug 54828 comments 25-29.
I just updated the build doc therefore.54828 

Comment 5

[Steffen Wilberg]

Benjamin, the Firefox build page still contains informations which are not
covered by http://www.mozilla.org/build/configure-build.html, like the aviary
branch, building the installer, and defaults regarding debug or non-debugs
builds (this bug).

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

I see the changes halfway down the page but the original text near the top is
unchanged. Perhaps the "Builds are optimized by default." can just be removed,
since the defaults are dealt with in the lower section. This is consistent with
the Static/shared case.

Also, should the date at the top of the page get updated ?

Comment 7

[Steffen Wilberg]

I commented out that sentence. It can be readded as soon as the aviary branch
has finally fulfilled its purpose.

I don't care that much about the date since the last modified date is displayed
at the bottom.

Comment 8

[Reed Loden [:reed]]

--> Websites :: www.mozilla.com so timeless can close out Firefox :: Product Site.