265240 - collectstats.pl cuts off crucial opening tag from duplicates.rdf file

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

collectstats.pl chops HTTP headers from the output of duplicates.cgi?ctype=rdf
to generate the static duplicates.rdf file, but it determines the end of HTTP
headers by checking for \n, and HTTP/1.1 defines \r\n as the end-of-line marker,
so instead of matching the empty line after the HTTP headers (which is delimited
by \r\n), collectstats.pl instead matches the empty line after the opening RDF
tag in the file (which is delimited by \n), and it chops off that line in
addition to the HTTP headers.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 162743 [details] [diff] [review]
patch v1: fixes problem

one liner review?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Thanks Christian.

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.40; previous revision: 1.39
done
Checking in ../bz218/collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.38.2.2; previous revision: 1.38.2.1
done