Closed Bug 265240 Opened 19 years ago Closed 19 years ago

collectstats.pl cuts off crucial opening tag from duplicates.rdf file

Categories

(Bugzilla :: Bugzilla-General, defect)

2.19
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: myk)

References

()

Details

Attachments

(1 file)

collectstats.pl chops HTTP headers from the output of duplicates.cgi?ctype=rdf
to generate the static duplicates.rdf file, but it determines the end of HTTP
headers by checking for \n, and HTTP/1.1 defines \r\n as the end-of-line marker,
so instead of matching the empty line after the HTTP headers (which is delimited
by \r\n), collectstats.pl instead matches the empty line after the opening RDF
tag in the file (which is delimited by \n), and it chops off that line in
addition to the HTTP headers.
Comment on attachment 162743 [details] [diff] [review]
patch v1: fixes problem

one liner review?
Attachment #162743 - Flags: review?(justdave)
Attachment #162743 - Flags: review?(justdave) → review+
Thanks Christian.

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.40; previous revision: 1.39
done
Checking in ../bz218/collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.38.2.2; previous revision: 1.38.2.1
done
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: approval2.18+
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.