265265 - grid lines dissapear in weekly view

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[andrew hull]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910

depending on the window size, some vertical gridlines do not get drawn on the
weekly. 

Reproducible: Always
Steps to Reproduce:
at full-screen 1280x1024 with hour range set to 8AM-7PM, there are 12 hour rows
displayed. every 3rd box is missing a line, no line appears between 9AM and
10AM; 12PM and 1PM; 3PM and 4PM; 6PM and 7PM.




modern theme

Comment 1

[Wm]

Reporter: do you mean vertical or horizontal?  Either way I think this is a
duplicate.

Comment 2

[andrew hull]

vertical, as described. and i couldnt find a dupe

Comment 3

[Wm]

surely if the lines are missing between the _hours_ in the weekly view it is the
hoz lines that are missing not the verts?  the verts are the lines between the
days.  (horizontal is normally left to right and vertical top to bottom when
talking in this context).  a screen shot would clarify the problem.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

I'm seeing this all the time. Quite likely rounding issues. Depends on the
window size.

Comment 5

[Wm]

I was just trying to clarify what Andrew said.  I don't see it here (the
vertical  lines problem as opposed to the horizontal one) so I'll leave it with
you and others, Michiel. (I run most windows full screen and switch between them
rather than tiling or similar).

Comment 6

[Martin Bagge / brother]

Attachment: Weekview with one missing line

Comment 7

[Martin Bagge / brother]

Attachment: Weekview with one missing line

(the other screenshot shows two missing lines not ONE)

Comment 8

[andrew hull]

oh damn, youre right. i obviously meant 'vertical' as in 'horizontal'

Comment 9

[gekacheka]

Attachment: calenadar.css, weekView.xul patch: use top border instead of bottom

(patch -l -p 2 -i file.patch)

Roundoff errors can cause boxes drawn later (right, below, inner) to overlap
the last pixel of boxes drawn earlier, so for grid use top/left borders instead
of bottom/right borders.

Patch changes bottom borders to top borders.  For bottommost border, uses
bottom border of column (border placed on column so easier to omit grid lines
from hours column if desired, this patch does not).

Column class "week-view-day-container-box" was used in both header grid and
hours grid, so the headers grid column class is renamed to
"week-view-header-day-column".

Comment 10

[Mostafa Hosseini]

Checked in. Thanks

Comment 11

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!