Open Bug 265277 Opened 20 years ago Updated 2 years ago

Bad keyboard mapping for "Don't Save" button when closing a used Compose window.

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
All
macOS
Type:
defect

Tracking

(Not tracked)

People

(Reporter: christopher, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [needs fix to bug 207510]) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

Thunderbird v0.8 (20040913)
Open a new compose window (cmd-m / cmd-shift-m) and type something anywhere.
Do a cmd-w to close the window and the (sheet?) dialog drops out of the title bar.
Pressing return does and OK and pressing cmd-period does cancel but cmd-d does
not map to "Don't Save" pressing Ctrl-d does.

This seems to be a minor oversight.

Chris

BTW looking for a duplicat bug I came accross a couple of other mac keyboard
based bugs. I can confirm that pressing the 'delete' key next to the home and
end keys does not delete a mail.
<https://bugzilla.mozilla.org/show_bug.cgi?id=242864>

Reproducible: Always
Steps to Reproduce:
1. Open compose
2. enter text and close window
3. press cmd-d, nothing happens
4. press ctrl-d, expected responce for cmd-d.
Actual Results:  
nothing

Expected Results:  
"Don't Save" to be triggered
it is just "d" (withoud cmd/ctrl) as any other mac app.
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → INVALID
I dissagree!!

1. Open the standard Apple app TextEdit.
2. Type something
3. Close window (cmd-w)
4. Press 'd'

You get a bleep, not the "Don't Save" option.

alternat 4. Press 'cmd-d'

You get the "Don't Save" option.

Try this on any other Apple app.

Regards

Chris
I don't want to get picky about this but in the light that I have tested your reasoning for Invaliding this 
and shown *that* to be invalid (tell me an non-mozilla app that DOES do what you say) I think that this 
is a valid 'oversight'.

Also if the shortcut of ctrl-d is mapped (blatantly a PC shortcut) then that should NOT be so.

I have been a Mac user for over 15 years and have a good feeling for the 'standards'. I also do some 
development.

I think that the work done here is great, I love Thunderbird but the Mac version is not yet polished. 
There is the odd interface quirk. The wake from sleep oddities. The occasional unresponsive dialog 
requiring a force quit and re-launch. But it is nothing terrible.

I am just trying to bring a small thing to the light of the developers and I don't feel happy being 
smacked away being told I am stupid. It is the one 'repeatable' bug that I have been able to nail down. I 
will try to report anything else when I can.

Please no that this is helping open-source to be better. Not saying that you have done a bad job.

Warm Regards

Chris
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
(In reply to comment #3)
> I don't want to get picky about this but in the light that I have tested your
reasoning for Invaliding this 
> and shown *that* to be invalid (tell me an non-mozilla app that DOES do what
you say) I think that this 
> is a valid 'oversight'.

Well, in OS X 10.2 it was just "d", it seems as Apple changed the native bahavior.

Confirmed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Out of interest in your comment I booted my Mac into the other OSs that I have installed.

10.2.8 with TextEdit 1.2 did not respond to just 'd' (only cmd-d)
9.2.2 with SimpleText DID respond to only 'd' (and also cmd-d)

I was suprised at that and am willing to understand your simple dismissal. I think that I have always 
used cmd-d as the other options are cmd-period and Return. From much command button pressing I 
must have missed the other alternative.

Also I am sure in some Apps (OS8/9) they use to show in text form under the button options the 
keyboard shortcuts, at least with the command button held down. Then the option was cmd-d.

Thanks for looking at this again.

Regards

Chris
Scott, can you find time before 1.0 for this seemingly minor change? I get
irritated by this very often. AFAIK Command D for Don't Save has always been a
standard Mac OS X key shortcut.
Flags: blocking-aviary1.0?
Bug 207510

Marking dependent, but it's actually a dupe.
Depends on: 207510
minusing. Too late for 1.0

I just took a look to try to fix it. If this dialog was a mailnews dialog and it
was just a matter of adding a key binding I would fix it. But we don't own the
dialog, it's a generic dom window prompt and changes to it effect all prompt
windows in all the mozilla apps.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
I run into this bug several times each day. It'd certainly make Thunderbird
easier to use for those of us who have keystrokes like Command-D memorized.

For example, it's not uncommon for me to rapidly run through the sequence
Command-R, Command-W, Command-D, Command-Shift-R if I accidentally reply to one
instead of reply to all.
Keywords: polish
QA Contact: message-compose
Hi,

It is three years from last post and bug is still here, in v 2.0...16 and even in 3alpha!!!

There is one important thing in Mac OS X. If have not enabled full keyboard access to dialogs you can't use just d until full access is enabled.

Ti is not default settings because in some dialogs in other apps you would have to dig through too many fields and buttons. It is not Apple prefered way for casual user. So right shortcut is so important.

Without full keyboard access you can't change formaty of message when sending mail.
Assignee: mscott → nobody
I don't seem to be able to assign an issue to myself and have no experience developing for Thunderbird, but this doesn't appear to be any closer to solved than it was 6 years ago and sounds like it should be a relatively simple fix, so I'm going to take a stab at it.
Thanks for reporting this, I hadn't noticed before.

I'm not certain here but I believe this is a toolkit bug and not a Thunderbird specific bug.  We get that dialog from the nsIPromptService which creates most of those types of dialogs so we would have to fix that in order to fix this.

Mark, does that sound right?  If so we should move this over to toolkit and perhaps supply a patch to that.
Hardware: PowerPC → All
(In reply to comment #13)
> Thanks for reporting this, I hadn't noticed before.
> 
> I'm not certain here but I believe this is a toolkit bug and not a Thunderbird
> specific bug.  We get that dialog from the nsIPromptService which creates most
> of those types of dialogs so we would have to fix that in order to fix this.

I'm not sure that's the specific place that needs fixing, but its somewhere around there.

> Mark, does that sound right?  If so we should move this over to toolkit and
> perhaps supply a patch to that.

Bug 207510, which this is dependent on, would seem to fix this. I think we should keep this bug here and the dependency, so I've just flagged this as would be fixed by that bug.
Whiteboard: [needs fix to bug 207510]

(In reply to Mark Banner (:standard8) from comment #14)

...
Bug 207510, which this is dependent on, would seem to fix this. I think we
should keep this bug here and the dependency, so I've just flagged this as
would be fixed by that bug.

Bug 207510 was closed. So is this still an issue in thunderbird?

Flags: needinfo?(adam)
See Also: → 768797

(In reply to Wayne Mery (:wsmwk) from comment #20)

Bug 207510 was closed. So is this still an issue in thunderbird?

Actually yes it is. I'm' suprised to find that CMD-D doesn't have any effect but CTRL-D does - it dismisses/discards the compose window.

CMD-whatever seems to work fine everywhere else, why not in that dialog?

(In reply to Wayne Mery (:wsmwk) from comment #20)

(In reply to Mark Banner (:standard8) from comment #14)

...
Bug 207510, which this is dependent on, would seem to fix this. I think we
should keep this bug here and the dependency, so I've just flagged this as
would be fixed by that bug.

Bug 207510 was closed. So is this still an issue in thunderbird?

It is still an issue. I don't think there are any macOS window-level controls that use "control" for anything. It's always "command".

It looks like Bug 768797 is covering this issue? Perhaps this one should be duped to it.

Flags: needinfo?(adam)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.