265325 - localized builds are packaging extra firefox-bin.elf

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Benjamin Smedberg]

The new firefox localized mac downloads have an extra firefox-bin.elf file in
them, which isn't needed and increases the size of the package significantly. I
think this is an artifact of the talkback-generation process and have a simple
patch to fix it.

Comment 1

[Benjamin Smedberg]

Attachment: Don't package it

Comment 2

[Jon Granrose]

hmm, we need to figure out why we're getting this in the l10n builds and not on
imola (ffox branch mac en-us).

Comment 3

[Benjamin Smedberg]

I don't know exactly how the talkback extracts symbols, but this may be caused
by the repackaging of dist/bin into dist/Firefox that is done for each locale.
If the talkback system munges dist/bin and expects dist/Firefox to stay around,
that could be causing the problems.

Comment 4

[Jon Granrose]

the mac packaging creates a dist/Firefox.app by copying / linking into dist/bin
so dist/bin is still around.

it appears the problem was due to some talkback problems we were having
yesterday.  today's release build pulled the fullsoft files, did the symbols
correctly and removed the .elf file.  So we can chalk this up to finicky servers.

Comment 5

[Martin Creutziger [:MMx]]

Today's builds (2004-10-22) show the same bug again. Reopening.
Is there some way this can be avoided?

Comment 6

[Chase Phillips]

Comment on attachment 162755 [details] [diff] [review]
Don't package it

r=cmp

Delayed review.  Problem went away after Talkback server was fixed.  This issue
reappears whenever there is a problem with the Talkback server during the build
process.  While this patch won't fix the fact that Talkback isn't in the build,
it should at least allow us to overlook an unneeded file during one of those
horked builds.

Comment 7

[Tuukka Tolvanen (sp3000)]

The localized firefox 1.0.6 linux non-installers are having this issue, now (bug
301387)

Comment 8

[Reed Loden [:reed]]

checked-in to trunk by timeless on 2005-12-16 12:47 (revision 1.22 of mozilla/browser/installer/Makefile.in)

Comment 9

[Reed Loden [:reed]]

*** Bug 301387 has been marked as a duplicate of this bug. ***