Add UI names for the IBM converters. momoi-san suggests: Western (CP-850) Central European (CP-852) Cyrillic (CP-855) Cyrillic/Russian (CP-866) Turkish (CP-857) Hebrew (CP-862) Arabic (CP-864) We need to confirm that we want to use CP- instead of IBM- in these names. Also, at this time, we probably don't want Arabic in the menu since we do not have bidi support yet, but we may want Hebrew since there are visual order Hebrew pages on the web.
firstname.lastname@example.org- comment ?
While you're at it, we need to add UI name for x-viet-tcvn, probably Vietnamese (TCVN) Other suggestions? Please note any other changes ASAP, so cata can do them all at the same time for Beta1.
I'll be working on these changes today. I don't think we want to prevent the Arabic and Hebrew from showing up on the More menu - there are fonts that can be used to cause Arabic and Hebrew to show properly if the web site has done visual Bidi. We need to allow users to access the character converters.
I just noticed that in charsetTitles.properties, 866 is in their twice - as cp-866 and as ibm866 - which is correct?
Mike, I know there are many visual Hebrew pages on the web, but are there visual Arabic pages out there?
Created attachment 5061 [details] [diff] [review] Addition of descriptive names for IBM charsets, fixing of Russian name
Mike, for Russian, I think we should match up with what we did with Ukrainian. Cyrillic/Ukrainian nad call it Cyrillic/Russian instead. Otherwise, we will have Russian (IBM-866) all by itself not under Cyrillic as we had under 4.7x. Or do we want all IBM encodings (for now) under More... ?
Our current proposal is to sort by UI names when we list items under the dynamic menu and that is why UI name grouping is rather important.
Have we decided anything w/regards to IBM-xxx vs. CP-xxx? Let's get this bug resolved ASAP and improve the usability for Beta1. We can/will further tweak this post-Beta1. momoi-san, Will you provide the final list, so Cata can check it in early?
Bob, Mike attached a diff of his proposal above. He suggests IBM- instead of CP-. I'm making one suggestion to change Russian (IBM-866) to Cyrillic/Russian (IBM-866) so that this encoding will sort under Cyrillic eventually.
In the current driver, 866 is actually on two menus two different ways: Character Set Cyrillic on the main menu has Cyrillic (CP-866) Character Set -> Character Set Cyrillic would have my version which one is correct? Why are there two Cyrillic menus?
Mike, the main menu is a temporary workaround for non-scrollable menu. The one under Character Set will take over soon, and the remporary one will disappear. Both of these actually engage ibm866 encoding and so they are redundant but the same thing. I don't think we have an MS converter table. Frank/Cata, don't we have only IBM convertes? Mike, you want to rename Cyrillic to Russian. I want to suggest Cyrillic/Russian for the new dynamic menu. The other one will go away.
Created attachment 5072 [details] [diff] [review] This diff has Cyrillic/Russian rather than Russian. Am I OK to check this in?
Cata, I'm OK with Mike's UI names. Bob?
Looks good to me. Let's go with these for Beta1!
And don't forget to add UI name for x-viet-tcvn, probably Vietnamese (TCVN)
Do you want me to go ahead and do the Vietnamese or someone else?
Mike, it would save us the time if you add Vietnamese while you're doing IBM- 's.
Mike, Please go ahead and check in your changes as well as the Japanese change. I just reassigned the bug to you. Thanks!
Assignee: cata → mkaply
Status: ASSIGNED → NEW
The IBM changes, as well as the Vietnamese change is in.
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
Added cata to the CC line. I'm satisfied that in 2/11/2000 builds, all the IBM encodings have proper UI names. The Vietnamese addition, Vietnamese (TCVN), mentioned above has been backed out since it was not needed -- there was prior inconsistency -- "x-viet-tcvn5712" is the real charset name we use in the code for what has been discussed as "x-viet-tcvn" above. Thus we have no need for the latter. There are a couple of issues left: A. m_kaply suggests that the current UI name for "x-viet-tcvn5712", Vietnamese (TCVN5712), probably should be more user-friendly Vietnamese (TCVN). We can do that sometime later, after Beta 1 perhaps. B. In the temporary charset menu, .Arabic (ISO-8859-6) .Hebrew (ISO-8859-8) These items were prefaced with "." indicating that though these menu items do work -- they will reload pages --, we don't guarantee that they work well. On the other hand, 2 Windows encodings for Arabic and Hebrew do not have a "." at the beginning. Should we leave these in as they are with no dots? I believe "." means that it will work to some extent but probably not fully -- that seems to be how we have been using "." under the encoding menu. Opinions?
The UI names have been corrected on Mac, Win and Unix on builds later than the 2/9/2000. Marking the fix verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.