265394 - bodyattrs should be dropped from header.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Bugzilla 2.19

After bug 251596, bodyattrs aren't really needed any more. What can be done with
bodyattrs should be done with CSS.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Frédéric Buclin]

Comment on attachment 171981 [details] [diff] [review]
Patch

looks good!

r=LpSolit

Comment 3

[Frédéric Buclin]

vladd, is a *third* review requested? ;)

Comment 4

[Vlad Dascalu]

No, but I thought that it's useful to specify in the bug that I looked over the
code myself and saw it as "review+" material.

Might be a useful thing to know for the one doing the approval? thing.

Comment 5

[Vlad Dascalu]

LpSolit: see the previous comment.

Comment 6

[Vlad Dascalu]

Since that came out wrong, I thought I could specify it better:

I didn't want to imply that my review would count more for the one doing the
approval? thing compared to yours. Sometimes however, for drivers/approval guys,
it's important to know how much testing a patch had, how many people looked over
it, etc, in order to decide in what branch it should go and so on. Having 2
reviews instead of 1 gives more information to them. While it's not "required",
I don't think people doing additional reviews should abstain themselves from
marking them on b.m.o.

Comment 7

[Shane H. W. Travis]

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <-
-  filterexceptions.pl
new revision: 1.31; previous revision: 1.30
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
  <--  header.html.tmpl
new revision: 1.34; previous revision: 1.33
done