265413 - .tabs-closebutton class should be globally defined in toolbarbutton.css (put class back on #find-closebutton)

Status: RESOLVED INVALID

(Firefox :: General, enhancement)

Description

[miahz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0

The find toolbar was recently given it's own stylesheet in global, but the close
button lost the .tabs-closebutton class, i assume because it was only defined in
browser/browser.css.  That class is still useful on that button for defining the
source image and hover and active states, which are the same for the tab bar,
side bar, message bars, and find toolbar.  The only things that change are
borders, and padding, which are easily handled on a per-case basis by using IDs.

If the .tabs-closebutton is moved to global/toolbarbutton.css, then it can be
picked up anywhere it needs to be used.

So the two things i'm asking for:
1. Move the basic styles to global
2. Return the .tabs-closebutton class to #find-closebutton, and use it on any
other close buttons in the future.

I'll be honest and admit that part of why i'm requesting this is because it
needlessly breaks my theme.  But it's also just a logical, more efficient and
consistent use of code.

Patch on the way...

Reproducible: Always
Steps to Reproduce:

Comment 1

[miahz]

Attachment: patch: tab close button class fix as described above

Moved base .tabs-closebutton styles to global/toolbarbutton.css.  Cleaned up
redundant styles in other style sheets.  Added .tabs-closebutton class to
#find-closebutton in browser/browser.xul.  No actual style changes were made -
i only translated and reorganized the existing code.  Everything looks and acts
just as it did before.

Comment 2

[miahz]

Comment on attachment 162835 [details] [diff] [review]
patch: tab close button class fix as described above

Kevin, this patch cleans up and globalizes styles for tabs close buttons.

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 5

[Martijn Wargers (dead)]

Well, the patch won't apply anymore, things have changed considerably since then.
Kevin, is this patch useful? Is this bug valid?

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 162835 [details] [diff] [review]
patch: tab close button class fix as described above

The patch is obsolete now.
The findbar close button has its own class now: .findbar-closebutton

Comment 7

[Martijn Wargers (dead)]

See:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/findBar.css#3
Where things are handled now.
I'm marking this bug invalid.