Often when I click on a virtual folder I'm noticing us do something strange with the quick search bar. If the quick search bar is just showing the greyed criteria text: "Subject or Sender", then the quick search bar 'forgets' that this is criteria text. The text shows up with black lettering and is now a searchable text string that quick search will search on if you were to focus the widget and hit enter. I'm not sure what the relationship is between opening a virtual folder and using code in SearchBar.js...
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.9
Created attachment 162915 [details] [diff] [review] work in progress this patch fixes the following scenarios: 1) clicking from a regular folder --> virtual folder that searches one folder, quick search bar no longer steals focus and clear criteria text. 2) clicking from a regular folder ---> virtual folder that searches multiple folders, quick search bar now no longer turns the criteria text into black colored quick search text. 3) clicking from a virtual folder that searches multiple folders --> to a regular folder, we no longer clear the quick search box and steal focus. Still broken: 4) Moving focus from a virtual folder that searches one folder to a regular folder. we are still clearing the quick search bar of its criteria text and putting focus in the text box. I'm stumped as to what code is doing this. Nothing in searchbar.js is geting called.
interesting, this last problem isn't virtual folder specific. I can also see if if I'm reading a non VF folder with a view turned on, then i click on another non VF folder. That steals focus into the quick search bar too.
Comment on attachment 162915 [details] [diff] [review] work in progress the last remaining issue has me stumped. But I won't hold up the rest of the fix for it.
Attachment #162915 - Flags: superreview?(bienvenu)
i added a dump by accident that I'll be taking out before i check in
Attachment #162915 - Flags: superreview?(bienvenu) → superreview+
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.