include custom stylesheets in header.html.tmpl

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

2.19
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Bug 256708 makes skins/custom/ for installation-specific custom stylesheets.  To
make use of this directory, header.html.tmpl needs to include references to
those stylesheets in Bugzilla page headers.  This is the fourth and final task
in the first stage of the Bugzilla CSS plan:

* classify pages by installation and CGI: bug 253480;
* move existing files to their new locations: bug 256207;
* make checksetup.pl create the skins/custom/ hierarchy: bug 256208;
* make header.html.tmpl include custom stylesheets: this bug;
(Assignee)

Comment 1

14 years ago
Created attachment 162886 [details] [diff] [review]
patch v1: implements feature
(Assignee)

Comment 2

14 years ago
Comment on attachment 162886 [details] [diff] [review]
patch v1: implements feature

This five-line patch adds support for custom stylesheets to Bugzilla.  It's the
last of the four tasks in round one of the CSS plan that still needs doing. 
The others are all in 2.20 already.  Gerv, any chance you can review this
adjunct to the other two you recently reviewed before you head off for a month?

Detail: This patch adds skins/custom/<foo>.css references to pages with
skins/standard/<foo>.css references.  custom/ comes after standard/ so it takes
precedence.  The patch doesn't support multiple third-party skins as alternate
stylesheets, and it leaves the standard stylesheets as "persistent" stylesheets
(applied always no matter what alternate stylesheet has been selected) since
the standard stylesheets only need to become preferred (applied by default, but
not applied when the user selects an alternate skin) once we support multiple
third-party skins as alternate stylesheets.

In other words, this patch is simple, but things will become more complex in
the future.
Attachment #162886 - Flags: review?(gerv)
Comment on attachment 162886 [details] [diff] [review]
patch v1: implements feature

r=gerv. Like the implementation.

Gerv
Attachment #162886 - Flags: review?(gerv) → review+
(Assignee)

Comment 4

14 years ago
Thanks Gerv!  Fix checked in, and stage one of CSS plan is complete.

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.30; previous revision: 1.29
done
Flags: approval+
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.