265537 - FireFox has issues parsing <marquee> tags with direction=up in the tag.

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[chris pitt]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

I don't know why this is being an issue, but FireFox seems to have a problem
with marquees going up where when its finished, theres a huge blank spot on the
bottom of the page. Now, I don't know if this is a major issue with Cable/DSL
users, but I'm on 56K so it would, if this is the type that requires a long
load, happen more often to me and other 56k users.

Reproducible: Sometimes
Steps to Reproduce:
1. Go to http://sws2b.dyndns.org:1124/forums/index.php?showuser=692
2. Wait for the page to finish loading.
3. When the page is finished, look at the bottom of the page.

Actual Results:  
After the page was finished, there was a huge blank spot at the bottom of the page.

Expected Results:  
It should of resized the site without leaving a huge blank spot at the bottom of
the page.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Mozilla sets the height of the direction="up" or direction="down" marquees as
high as the the height of the content inside the marquee.
But that's not what IE6 is doing. IE6 automatically sets the height of the
direction="up" or direction="down" marquees to 200px when no height is given in
some other way for the marquees.

Comment 2

[Martijn Wargers (dead)]

Attachment: Good testcase

Argh! Previous testcase was wrong. Sorry.

Comment 3

[Martijn Wargers (dead)]

Attachment: css patch

Something like this fixes it.

Comment 4

[Martijn Wargers (dead)]

Hmm, actually a bit strange that it works. 
Setting marquee{height:500px;} makes the marquee 500px high with the fix in
html.css.
Normally, I would expect that the marquee would stay at a height of 200px with
the fix, since the marquee[direction="up"] selector has a higher specificity.

Comment 5

[Doron Rosenberg (IBM)]

http://lxr.mozilla.org/aviarybranch/source/layout/html/document/src/xbl-marquee/resources/content/xbl-marquee.xml#207

That is supposed to make it 200 if no height is set.

Comment 6

[Martijn Wargers (dead)]

Ah, thanks! But what lxr is showing is not what is currently in the trunk.
The fix for bug 262708 is probably the cause for this regression I described.
Moving the old code back in fixes it. 

But that makes me believe that the reporter is seeing a different bug, since he
uses the 1.7 branch. 

Comment 7

[Boris Zbarsky [:bzbarsky]]

I'm betting the problem is that computed style returns "auto", which we then
proceed to use as the height in preference to "200" (since auto tests non-null
in JS).  I agree that that's not what the original bug is about.  Martijn, could
you file a separate bug on the marquee height issue on trunk?

Comment 8

[Martijn Wargers (dead)]

Ok, I filed bug 265631 on that.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #6)
> Ah, thanks! But what lxr is showing is not what is currently in the trunk.

that depends. the link doron gave is indeed from the aviary branch. if you want
trunk, replace aviarybranch with seamonkey (or mozilla)

Comment 10

[Martijn Wargers (dead)]

Attachment: patch2

Yeah, I was very consistently confusing a trunk bug (bug 265631)  with a branch
bug (this bug, which is an incremental reflow bug and not visible anymore in
the trunk).

This seems to workaround the incremental reflow bug, by not letting the large
height of the marquee happen (before the document has finished loading).
I've included the patch from bug 265631, otherwise it would not solve this bug.


I've added overflow: -moz-scrollbars-none; to the marquee selector and moved it
out of anonymous <div>s in the marquee binding.

Comment 11

[Mats Palmgren (inactive)]

*** Bug 305286 has been marked as a duplicate of this bug. ***

Comment 12

[j.j.]

This works for me with FF 2 and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070204 Minefield/3.0a2pre

Comment 13

[Martijn Wargers (dead)]

Yeah, marking worksforme, you won't see this anymore on trunk because the 200px height was added in bug 265631.
I guess this might still be an issue on branch, but we shouldn't bother with that anymore, anyway.