265540 - Should not be able to create a virtual folder with null subject

Status: NEW

(Thunderbird :: Search, defect)

Description

[Marcia Knous [:marcia]]

Seen using today's nightly: version 0.8 (20041021)

STR

1. Go to File | New | Save Search
2. Enter a name and other params, but don't fill in any search criteria.
3. Tbird creates a Virtual folder with a blank search.

Should the behavior be more like Filters, where we throw up a dialog that says
"You must create at least one filter action?"

You can go back and edit the Virtual Folder (and it does work, I tried it) but
it seems to me it might be better to force the user to choose his search
criteria at the time the folder is created.

Comment 1

[Scott MacGregor]

(In reply to comment #0)
> 
> Should the behavior be more like Filters, where we throw up a dialog that says
> "You must create at least one filter action?"

That's not really true. You can create a mail filter without specifying any
search terms. You can also create a advanced search without specifying any
search terms. In fact, none of our dialogs where we allow you to enter search
terms are smart enough to detect if you've entered any search criteria. 

I just tried to fix this. It's currently not very easy to tell if all of the
created search terms are empty without digging down into the individual values
of each search term that we've created in the UI. 

Moving this off the 1.0 plate after this analysis. 

Comment 2

[Mikael Nilsson]

Actually, I would *want* to be able to specify empty search criteria.

I have a simple reason: I have a vFolder containing all my incoming mail (sorted
into different folder for different mailing lists, etc). I've had to specify
"Date > 1960" or similar to get *all* messages in the chosen folders.
Effectively, this is a "collection" vFolder.

I then use this folder as a base for further searches. Unfortunately, TB does
not allow me to specify this folder as a source folder when creating new
vFolders. Evolution handles this fine.... the single thing that I find evo does
better atm is vFolder handling (but it is much slower than TB).

/Mikael

Comment 3

[Scott MacGregor]

bumping per my earlier comments

Comment 4

[Daniel Kabs, reporting bugs since 2002]

> 1. Go to File | New | Save Search
... does not exist any more

This report is so old it should be resolved as "outdated", pity this resolution does not exist.

Comment 5

[Daniel Kabs, reporting bugs since 2002]

(In reply to comment #4)
> > 1. Go to File | New | Save Search
> ... does not exist any more
> 
Uppps..  It does exist. After I selected a folder, this menu item appeared.

Sorry my fault. If this is a bug, it's still in there.

Comment 6

[Wayne Mery (:wsmwk)]

and, I am unable to delete it
Error: An error occurred executing the cmd_delete command: [Exception... "'[JavaScript Error: "bundle is not defined" {file: "chrome://messenger/content/folderPane.js" line: 2203}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 96"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 100

(no doubt a different bug)

Comment 7

[:aceman]

Wayne, but are you able to reproduce it? In current TB the search is not empty. There is a "Subject,is," condition prefilled in that dialog. That seems like it could be a valid condition.

I can see the error you describe. But where did you get such verbose output? In my error console, I just get file and line number.

But I think I could fix that one.

Comment 8

[Wayne Mery (:wsmwk)]

yes, I can reproduce.  thinking more about this, it might be a duplicate - but have no energy to do the search :(

in any event, a null subject yields no search hits, so it's probably an unhelpful/unhealthy state

don't know why i got more verbose error - perhaps a gloda setting?

Comment 9

[:aceman]

Yes, that search condition may be unhelpful, but does not cause any crashes or unsupported state. The same "problem" exists in Filters definition. This would need some decision from module owner if TB should not allow this condition.

I have a patch for the "bundle is not defined" error. If you can find the bug for it I can post it straight away.

Comment 10

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #9)
> I have a patch for the "bundle is not defined" error. If you can find the
> bug for it I can post it straight away.
FTR, we handled this in bug 708315.

I did not find a duplicate bug. But there is at least one related bug 440875

Comment 11

[:aceman]

It seems to me this bug here is more about having NO rules in the virtual folder criteria.
On the other hand bug 440875 seems about having 1 rule but the value for the criteria being empty (or ""). That looks more like bug 1034408.