265574 - [midas] Undo not working when editing a table programmatically

Status: RESOLVED INVALID

(Core :: DOM: Editor, defect, P5)

Description

[Nuutti-Iivari Meriläinen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

  When adding/removing columns/rows programmatically in a table inside an iframe
with designMode="on", undo doesn't work at all.

Reproducible: Always
Steps to Reproduce:
1. Open the provided attachment
2 [review]. Use the buttons to add and delete columns and rows.
3. Push the "Undo" button at any time after adding/deleting rows/columns.

Actual Results:  
  If a table cell is selected, the table's resize handles and inline editing
widgets are repositioned correctly (see bug #265568). No undo actions are
performed, the table is unchanged.

Expected Results:  
  The programmatical modifications should have been undoed.

  Also reproducible on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20040910.

Comment 1

[Nuutti-Iivari Meriläinen]

Attachment: Test case HTML/script for the bug

Comment 2

[Nuutti-Iivari Meriläinen]

  Undo via CTRL-Z shortcut doesn't work either.

Comment 3

[Martijn Wargers (dead)]

You are using standard dom methods, instead of midas specific commands. That's
why undo doesn't work.
It would be nice though if Mozilla also made those methods undoable in a midas
window.

Comment 4

[Nuutti-Iivari Meriläinen]

(In reply to comment #3)
> You are using standard dom methods, instead of midas specific commands. That's
> why undo doesn't work.

  I suppose that this bug, then, applies to everything done through the DOM -
not just tables - and that only things done through the execCommand interface
are undo/redoable.

Comment 5

[Frank Wein [:mcsmurf]]

Related/Dupe of Bug 236183?

Comment 6

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 7

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.

Comment 8

[Jane]

When editing a table programmatically, the undo function may not work due to the way the changes are being made. To enable undo functionality, you can use the document.execCommand method in JavaScript to modify the table and execute built-in browser commands, including undo and redo. By using this method, any changes made to the table programmatically can be undone by the user. Source https://apkhexo.com/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We have no plan to fix this because editor apps should have their own undo transactions if they touch the DOM tree directly. Once we would fix this, Firefox wasted a lot of memory for the mutations to make them undoable even though they were overridden by the apps.