Closed Bug 265607 Opened 20 years ago Closed 19 years ago

logic error in GtkPromptService::Prompt

Categories

(Core Graveyard :: Embedding: GTK Widget, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chpe, Assigned: chpe)

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 Galeon/1.3.17.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 Galeon/1.3.17.99

GtkPromptService::Prompt
[http://lxr.mozilla.org/seamonkey/source/embedding/browser/gtk/src/GtkPromptService.cpp#184]
:
184     if (aConfirm) {
185         if (*aValue)
186             nsMemory::Free(*aValue);
187         prompter.GetTextValue(aValue);
188     }

It checks aConfirm, but should check *aConfirm for whether to get the value from
the prompter, like ::PromptUsernameAndPassword and ::PromptPassword do. Patch
coming up.

Reproducible: Always
Steps to Reproduce:
Attached patch fix (obsolete) — Splinter Review
Attachment #163007 - Flags: review?(blizzard)
-> marco
Assignee: blizzard → marco
Attachment #163007 - Flags: review?(blizzard) → review?(marco)
Attachment #163007 - Flags: review?(marco) → review+
Attachment #163007 - Flags: superreview?(blizzard)
Attachment #163007 - Flags: superreview?(blizzard) → superreview?(roc)
Attachment #163007 - Flags: superreview?(roc) → superreview+
Comment on attachment 163007 [details] [diff] [review]
fix

A simple, gtk embedding-only fix, no risk.
Attachment #163007 - Flags: approval1.8b4?
Attachment #163007 - Flags: approval1.8b4? → approval1.8b4+
Assignee: mpgritti → chpe
Status: UNCONFIRMED → NEW
Ever confirmed: true
trunk:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.9; previous revision: 1.8
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.8.2.1; previous revision: 1.8
done
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: