265631 - [FIXr]Marquee with direction up or down and no height set whatsoever doesn't get 200px height anymore

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041020 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041020 Firefox/0.9.1+

This is a regression from bug 262708. 
The problem is that something <marquee direction="up"> gets the height of the
content that is inside now, when no height is set for the marquee.
Previously it got a 200px height, and that is correct behavior, since that is
what IE is doing also.

Reproducible: Always
Steps to Reproduce:
1. See testcase
2.
3.

Actual Results:  
Height of the marquee is as large as the content inside the marquee

Expected Results:  
The marquee should become 200px high.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

The problem is that the computed style is nonzero and non-auto -- it's the
intrinsic height...

So Martijn's suggestion from bug 265537 is the right way to go (except I
changed his second rule to catch cases like |height=""| or |height="0"| and not
switch to auto height for those).

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 163027 [details] [diff] [review]
Patch

sr=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.