265632 - it should be possibe to make RTL installer

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect)

Description

[Tsahi Asher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910

currently there is no option in the installer config.ini file to make it flow
from right to left. therefore, it is impossible to localize the installer
program to languages written from right to left (hebrew, arabic etc.).
attempting to do so will break the lines at their begining (right end) instead
of at their end.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




as far as i know, the hebrew support in win32 is not consistent. hebrew
applications written for win98 may not work properly on winxp/2k, and vice
versa. to the best of my knowledge (i have no expirience in programing with
hebrew) software that needs to work on both these systems needs first to
identify on what it's running on exactly.

the problem is similar for seamonkey, firefox and thunderbird.

i'm not sure about the component here. could also be installer or layout: bidi.

Comment 1

[Asaf Romano (gone)]

I suppose it applies the linux installer as well.

Comment 2

[Reuven Gonen]

from opening the installer setuprsc.dll file with ResHack, it seems like the way to change the dialog direction is by adding EXSTYLE WS_EX_LAYOUTRTL in the http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/installer/windows/wizard/setuprsc/setuprsc.rc file. for instance:

STYLE DS_MODALFRAME | WS_MINIMIZEBOX | WS_POPUP | WS_VISIBLE | WS_CAPTION | 
    WS_SYSMENU

EXSTYLE WS_EX_LAYOUTRTL /* make the dialog RTL */

will change the dialog to RTL.

the problem now is, how to apply this only to RTL languages...

there is also an issue of fixing the items in the dialogs once the installer is RTL.

i will add screenshots later.

Comment 3

[Reuven Gonen]

Attachment: wizard dialog, set to RTL

Comment 4

[Reuven Gonen]

Attachment: screenshot of dialog in ResHack, before change

this screenshot shows the settings of the license agreement dialog before the RTL setting applied.

Comment 5

[Reuven Gonen]

Attachment: screenshot of dialog in ResHack, after change

this shows the licence agreement dialog after adding
EXSTYLE WS_EX_LAYOUTRTL  (Line 3)

Comment 6

[Simon Montagu :smontagu]

For windows I think we need to add an "interface direction" key to config.it and then on WM_INITDIALOG for each property sheet call SetWindowLong() with GWL_EXSTYLE to add WS_EX_LAYOUTRTL when the direction is right to left.

This will work on RTL-enabled versions of Win98 and WinME, and all versions of W2K and WXP. It will not work on Win95 or NT.

Comment 7

[Reuven Gonen]

seems like this got fixed on windows by the Nsis installer. is this fixed on linux as well?

Comment 8

[Tomer Cohen :tomer]

(In reply to comment #7)
> seems like this got fixed on windows by the Nsis installer. is this fixed on
> linux as well?

Probably not, as NSIS available for Windows platform only.

Comment 9

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 10

[(no longer active)]

Resolving as WORKSFORME, because the NSIS Windows installer is capable of generating RTL installer UI, and we don't have installers for other platforms.