265644 - When querying multiple repositories, broken links from cvsquery.cgi

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Bonsai, defect)

Description

[Christian Reis]

When we have multiple repositories and list checkins in all repositories from
cvsquery.cgi, broken links are generated. The reason is that we are using a
single CVS_ROOT everywhere, and files listed there can be in various different
repositories.

I have a rather hackish patch in hand that works. I suspect CVS_ROOT should be
nuked but I'll leave that up for grabs.

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix

Comment 2

[timeless]

Comment on attachment 163034 [details] [diff] [review]
kiko_v1: fix

mozilla/webtools/bonsai/cvsquery.cgi 	1.53

kiko: please verify this was applied correctly...

Comment 3

[timeless]

ok this isn't fixed. the javascript code is broken. output looks like this:

<tr>
<TD width=2%><font face='Arial,Helvetica' size=-2>2005-12-12&nbsp;07:08</font><TD width=2%><a href='http://webtools.mozilla.org/registry/who.cgi?email=bsmedberg%25covad.net' onClick="return js_who_menu('bsmedberg%25covad.net','',event);" >bsmedberg%covad.net</a>
<TD width=45%><a href='cvsview2.cgi?subdir=mozilla/js/src/xpconnect/shell&files=xpcshell.cpp&command=DIRECTORY&branch=&root=/cvsroot'
 onclick="return js_file_menu(/cvsroot, 'mozilla/js/src/xpconnect/shell','xpcshell.cpp','1.91','',event)">
mozilla/<wbr>js/<wbr>src/<wbr>xpconnect/<wbr>shell/<wbr>xpcshell.cpp
<TD width=2%><font face='Arial,Helvetica' size=-2><a href='cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/js/src/xpconnect/shell&command=DIFF_FRAMESET&file=xpcshell.cpp&rev1=1.90&rev2=1.91&root=/cvsroot'>1.91</a></font>
<TD width=2%><TT><FONT SIZE=-1>&nbsp</FONT></TT>
<TD width=2%><font face='Arial,Helvetica' size=-2>2/0</font>&nbsp
<TD WIDTH=45% VALIGN=TOP>Bug <A HREF="https://bugzilla.mozilla.org/show_bug.cgi?id=315090">315090</A> - convert xpconnect utils/tests to use frozen linkage, r=shaver
</tr>

And it really upsets IE.

Comment 4

[timeless]

Attachment: quote text

Comment 5

[Christian Reis]

Comment on attachment 212215 [details] [diff] [review]
quote text

sure

Comment 6

[Frank Wein [:mcsmurf]]

Comment on attachment 212215 [details] [diff] [review]
quote text

one review is enough

Comment 7

[timeless]

Comment on attachment 212215 [details] [diff] [review]
quote text

mozilla/webtools/bonsai/cvsquery.cgi 	1.55

Comment 8

[:Gavin Sharp [email: [e-mail]]]

*** Bug 340408 has been marked as a duplicate of this bug. ***

Comment 9

[Adam Muntner [:adamm] (use NEEDINFO)]

Bonsai was decommissioned, closing all remaining bugs "wontfix"