265679 - requests error complaining about lack of group membership shows &bnsp;

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

" You asked [e-mail] <[e-mail]>  for
superreview on bug 249322, attachment 163059 [details] [diff] [review], but that bug&bnsp; has been
restricted to users in certain groups"

that should be &nbsp; probably.

Comment 1

[Frédéric Buclin]

Attachment: remove &bnsp;

typo error in user-error.html.tmpl

Comment 2

[Vlad Dascalu]

Comment on attachment 163124 [details] [diff] [review]
remove &bnsp;

This causes unpredictable results depending on whether pre-chomping is turned
on or off in template toolkit. When [% terms.bug %] ends on a line, then no
space is added after it if chomping is turned on.

To prevent that, either add a + sign after it:

[% terms.bug +%]

Or maybe even better, reword so that [% terms.bug %] is in the middle of the
line.

Comment 3

[Vlad Dascalu]

"Reword" means something in the lines of:

+    but that [% terms.bug %] has been restricted to users in certain groups, 
+    and the user you asked isn't in all the groups to which
+    the [% terms.bug %] has been restricted.

Comment 4

[Vlad Dascalu]

It would be cool to see if the problem appears on the tip, on 2.18-BRANCH and/or
on 2.16, and to set the target milestone field accordingly.

Also, I don't know what is our current template versioning policy, but it may be
needed to change the version from 1.0 to 1.1 at the beginning of the template.
Since this is a minor change though, I'm not sure it's required.

Comment 5

[Frédéric Buclin]

Attachment: remove &bnsp;, v2

[% terms.bug %] is now in the middle of a line.

Comment 6

[Frédéric Buclin]

(In reply to comment #4)
> It would be cool to see if the problem appears on the tip, on 2.18-BRANCH

Yes, this problem also affects the 2.18 branch.

Comment 7

[Vlad Dascalu]

Apparently this is applicable to 2.18 and trunk.

Comment 8

[Vlad Dascalu]

Comment on attachment 163149 [details] [diff] [review]
remove &bnsp;, v2

Not sure about keeping the 1.0 versioning, I guess the one doing the approval
will have to say something about that.

Comment 9

[Vlad Dascalu]

Upside about keeping 1.0: no wording changed, so the translators don't need to
look up the new version and waste their time.
Downside regarding not upgrading to 1.1: translators will not look up to the new
patch, and will not remove &bnsp; from their translated templates.

Looking from this point of view, changing to 1.1 would be appreciated. However,
we don't have many templates that have 1.1 as a version, and we haven't
implemented until now this versioning system, so I'm not sure it makes sense.
Since we have localization-freeze for 2.18 in effect, justdave might know more
about this kind of stuff.

Comment 10

[Dave Miller [:justdave]]

I'm ambivalent about the versioning.  Until we have a way to test them I'm not
too concerned.

Comment 11

[Christian Reis]

Me neither; keep it at 1.0 IMO.

Comment 12

[Vlad Dascalu]

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.73; previous revision: 1.72
done

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.61.2.4; previous revision: 1.61.2.3
done