265719 - "About Popup Blocking" dialog has screenshot of old UI

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Ali Ebrahim]

When the yellow popup information bar shows up, and you click and it select the
option that says not to show the yellow bar anymore, you get the "About Popup
Blocking" dialog box. This dialog box has a screenshot of old UI, with the many
vertical bars present as they were in Firefox 1.0 PR.

I will attach a screenshot in a moment. Also, I put this in the Toolbars
component of lack of a better place to put it. Feel free to move it somewhere else.

Comment 1

[Ali Ebrahim]

Attachment: Screenshot of "About Popup Blocking" dialog with old UI

See where the blue arrow is, lots of vertical bars. These are no longer in the
current UI. Yes, it's a minor difference.

Comment 2

[Ali Ebrahim]

Moving to Help Documentation. Seems like it's better suited to there.

Comment 3

[Jeff Walden (gone starting June 8)]

This is most definitely /not/ Help Documentation; there's no real good component
for it except General, but we all know how much attention bugs there get
compared to bugs in other components.

That said, this looks easy enough to fix that I'll still take the bug.  Because
of how the icon display code works in the main window, the best bet is probably
to just remove the other buttons from display in the dialog.  I'll look into
this more sometime in the next few days or so.

Incidentally, is this branch or trunk?  A semi-old branch nightly doesn't show
this (albeit a Linux build, not a Windows build).

Comment 4

[Ali Ebrahim]

I was using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20041022 Firefox/1.0.

Sorry about the component issue. I *thought* this was the most appropriate place
out of the ones on offer, since it 'helped' to explain something; and I hate
shunting stuff into general for the reason you mentioned.

Comment 5

[Steffen Wilberg]

It's not a screenshot, it's a real statusbar. Even the resizer displayed there
works: you can use it to resize the dialog. That's bug 184350, which is a
different issue.

Have a look at this, compare it with browser.xul, and you know how to fix it:
http://lxr.mozilla.org/aviarybranch/source/browser/base/content/pageReportFirstTime.xul

This is branch indeed.

Comment 6

[Jeff Walden [:Waldo]]

If indeed this still exists, I'll get to it sometime over Christmas break (after
a couple weeks or so -- my computer won't let me test fixes, so it'll have to
wait until I get Dell to fix it).  If this doesn't exist, feel free to close the
bug.  (If it does, don't bother commenting to that effect -- I'll find out when
I try to fix it.)

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Remove statusbar panels for the non-existent icons

The patch removes all statusbarpanels except for the one containing "Done." and
the one containing the blocked popup icon.  It's theoretically possible to make
what currently exists more accurately reflect the UI when the message is shown,
but there's no real reason to do so because many situations won't trigger UI
exactly like what's shown in the popup anyway.

Comment 8

[Mike Shaver (:shaver emeritus)]

Comment on attachment 169117 [details] [diff] [review]
Remove statusbar panels for the non-existent icons

a=shaver

Comment 9

[Jeff Walden [:Waldo]]

Patch in, marking FIXED.