26579 - purify reports UMR in nsString::DetermineRadix()

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[buster]

several reports:

[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {75 
occurrences}
    Reading 1 byte from 0x0012f215 (1 byte at 0x0012f215 uninitialized)
    Address 0x0012f215 points into a thread's stack 
    Address 0x0012f215 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[nkfile.dll]


[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {75 
occurrences}
    Reading 1 byte from 0x0012f215 (1 byte at 0x0012f215 uninitialized)
    Address 0x0012f215 points into a thread's stack 
    Address 0x0012f215 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[nkfile.dll]
[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {71 
occurrences}
    Reading 1 byte from 0x0012f215 (1 byte at 0x0012f215 uninitialized)
    Address 0x0012f215 points into a thread's stack 
    Address 0x0012f215 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[nkfile.dll]

[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {75 
occurrences}
    Reading 1 byte from 0x0012f215 (1 byte at 0x0012f215 uninitialized)
    Address 0x0012f215 points into a thread's stack 
    Address 0x0012f215 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[nkfile.dll]
[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {71 
occurrences}
    Reading 1 byte from 0x0012f215 (1 byte at 0x0012f215 uninitialized)
    Address 0x0012f215 points into a thread's stack 
    Address 0x0012f215 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[nkfile.dll]
[W] UMR: Uninitialized memory read in nsString::DetermineRadix(void) {63 
occurrences}
    Reading 1 byte from 0x0012f349 (1 byte at 0x0012f349 uninitialized)
    Address 0x0012f349 points into a thread's stack 
    Address 0x0012f349 is 53 bytes below the frame pointer in 
nsString::DetermineRadix(void)
    Thread ID: 0x11a
    Error location
        nsString::DetermineRadix(void) [xpcom.dll]
        nsString::ToInteger(int *,UINT)const [xpcom.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[appshell.dll]
        DllGetClassObject [GKWEB.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetInterface::=(nsGetInterface const&) [urildr.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]
        nsGetServiceByCID::nsGetServiceByCID(nsID const&,nsISupports *,UINT *) 
[necko.dll]

Comment 1

[rickg]

Yeah, yeah.

Comment 2

[rickg]

This appears to be fixed in my string testbed. I'll land it with my next major 
update.

Comment 3

[rickg]

Fixed by update last night.

Comment 4

[buster]

code level fix, verified with purify

Comment 5

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/a7cba258a513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26579 - Remove all unused strings marked moz:removedIn <= 103