265853 - "File" menu items listed in menu_reference.xhtml in wrong order

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Alexander L. Slovesnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041023 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041023 Firefox/1.0

In "File" menu there are such items in following order:
Close Window
Close Tab

In menu_reference.xhtml:
 
   <h3 id="close_tab">Close Tab</h3>
   <p>Closes the current tab and selects the rightmost tab. This menu item is
    visible only if more than one browser tab is currently open.</p>
 
   <h3 id="close">Close (Window)</h3>
   <p>Closes the current window.</p>

One more thing - why there are round brackets around "window" in "Close Window"?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Steffen Wilberg]

Indeed. The menu items were interchanged by bug 248021 (branch checkin
2004-09-25 08:32).

It's "Close (Window)" because it's "Close" if the tab bar is not displayed. You
have to deselect the "hide the tab bar" checkbox in Options-Advanced if you want
to hide it.

Comment 2

[Steffen Wilberg]

Argh, this is the same place I just modified in bug 263762. I'll attach a new
patch in that bug, which fixes this one as well.

*** This bug has been marked as a duplicate of 263762 ***

Comment 3

[Steffen Wilberg]

Sorry for the confusion. This is of course not about shortcuts. Reopening.

Comment 4

[Steffen Wilberg]

Attachment: move Close Window above Close Tab in the menu reference

Comment 5

[Alexander L. Slovesnik]

(In reply to comment #4)
> Created an attachment (id=163277)
> move Close Window above Close Tab in the menu reference
> 
Steffen, don't you think that you need to update firebird-toc.rdf too?
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/firebird-toc.rdf#270
<rdf:li> <rdf:Description ID="menu-file-close-tab" nc:name="Close Tab"
nc:link="menu_reference.xhtml#close_tab"/> </rdf:li>
<rdf:li> <rdf:Description ID="menu-file-close" nc:name="Close (Window)"
nc:link="menu_reference.xhtml#close"/> </rdf:li>
  

Comment 6

[Steffen Wilberg]

Comment on attachment 163277 [details] [diff] [review]
move Close Window above Close Tab in the menu reference

Indeed. Thanks for noticing!

Comment 7

[Steffen Wilberg]

Attachment: also fix the toc

Comment 8

[Jeff Walden (gone starting June 8)]

Comment on attachment 163329 [details] [diff] [review]
also fix the toc

r=me

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 163329 [details] [diff] [review]
also fix the toc

a=asa

Comment 10

[Steffen Wilberg]

Checked in br & trunk.

Comment 11

[Tracy Walker [:tracy]]

verified with windows firefox build 2004102607