265863 - Stalk words can be added multiple times

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Jonathan Watt [:jwatt]]

We should check if a word is already being stalked before adding it to the list
of stalk words or else /unstalk may appear not to work since it only searches
for and removes one instance of a stalk word.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[James Ross]

Comment on attachment 163222 [details] [diff] [review]
patch

>+    if (notStalkingWord)
>+    {
>+        list.push(e.text);
>+        list.update();
>+    }
> 
>     display(getMsg(MSG_STALK_ADD, e.text));

Is it appropriate to still say "Now stalking foo." when actually the word is
already in the list?

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: alternative patch

I don't really care since I don't think it's all that important whether the
word was already added. I'd rather save the footprint. Here is an alternative
patch which I think should do what you want though. Unfortunately I haven't
been able to test it because my trunk builds of chatzilla aren't managing to
connect to a server.

Comment 4

[Jonathan Watt [:jwatt]]

I'm sure there's probably a better name than "MSG_ALREADY_STALK_ADD" if someone
wants to suggest one?

Comment 5

[:Gijs (he/him)]

Maybe MSG_STALK_USED or MSG_STALK_PRESENT ? Just some suggestions :)

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: new patch

Okay, here's a new patch. I decided to use MSG_STALKING_ALREADY, but thanks for
the suggestions. :) This patch also alphabetisizes the list of stalk items
before it is displayed to make it easier to see what words you are or aren't
stalking.

Hannibal has kindly offered to test the patch for me since I currently can't do
it myself. I'll request review after that if everything works okay.

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: patch making add case-insensitive

Also make sure "word" can't be added if "WORD" is being stalked.

Comment 8

[:Gijs (he/him)]

I tested the latest patch which added the case insensitivity (ID 166097).
Everything seems to work as it should.

Comment 9

[Jonathan Watt [:jwatt]]

Silver, can you check this in for me please? If so please used my full email
address in the comment, not jwatt. I.e. p=[e-mail]

Comment 10

[Jonathan Watt [:jwatt]]

Silver checked in:
http://bonsai.mozilla.org/cvsquery.cgi?who=silver%25warwickcompsoc.co.uk&date=explicit&mindate=2004-11-29+05%3A41&maxdate=2004-11-29+05%3A41