265910 - nsToolkitProfileService nsCOMPtr abuse

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Stephen Walker]

Bustage from Neil's bug 253941 checkin.

c:/Mozilla\mozilla\toolkit\profile\src\nsToolkitProfileService.cpp(499) : error
C2679: binary '=' : no operator found which takes a right-hand operand
 of type 'nsIToolkitProfile *' (or there is no acceptable conversion)

bz_gone: swalker: um... that code is correctly breaking
bz_gone: swalker: it's making EXACTLY the mistake this checkin was supposed to
catch.
bz_gone: swalker: as in, it's just bogus
bz_gone: swalker: I could "fix" the toolkit bug so it builds
bz_gone: swalker: but the code is wrong, and in general will crash
bz_gone: swalker: I checked in a build bustage fix.

Comment 1

[Benjamin Smedberg]

Well, the bustage fix looks ok. The cast is OK only because we have special
knowledge that nsToolkitProfile is the only implementer of that interface.