265983 - Popup creation leads to GTK warnings

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Gtk-WARNING **: invalid cast from `(unknown)' to `GtkObject'
warning: attempted to CreateNative() width a non-superwin and non gtk container
parent


The problem is that we get the native data off a ChildWindow and try to use it
as the parent for the popup's native widget.  This fails, apparently.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 265982 has been marked as a duplicate of this bug. ***

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Basically we just need to call GetNativeData(NS_NATIVE_WIDGET) instead of
NS_NATIVE_WINDOW; the former gets us a 'superwin' which GTK1
nsWindow::NativeCreate can use, the latter gets us nothing which can be used by
nsWindow::NativeCreate. This is safe for other platforms because on Mac,
Windows and GTK2 NS_NATIVE_WINDOW and NS_NATIVE_WIDGET return exactly the same
thing.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 163780 [details] [diff] [review]
fix

r+sr=bzbarsky.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in. I think this is the last of the fallout from the widget change
batching...