266000 - Bookmarks toolbar folder links to firefox product page

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Axel Hecht]

What happens with the link in the toolbar bookmarks folder? The en-US version 
still links to http://www.mozilla.org/products/firefox/index.html, not sure if 
that's intentional. I recall Bart saying that that should point to 
http://www.mozilla.org/products/firefox/central.html, but that may be just me.

Comment 1

[Robin Monks]

What version are you using currently?

Comment 2

[Rafael Ebron (:rebron)]

Hi Vlad,

Simple fix in bookmarks.html.  If you could change "Firefox Home"
http://www.mozilla.org/products/firefox/index.html

to point to: 
http://www.mozilla.org/products/firefox/central.html

The difference between the pages is the former page is more "marketing" and
"download me" based.

The latter page is, here's what you can do with Firefox. 

Comment 3

[Rafael Ebron (:rebron)]

Getting Started lnk on the personal toolbar should also point to this page:
/products/firefox/central.html versus index.html

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: Two liner

Patch as requested.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 163400 [details] [diff] [review]
Two liner

r=vladimir

Comment 6

[Steffen Wilberg]

That's not exactly this bug, but we link to a couple of start pages here:
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser-region/region.properties

We may want to redirect http://www.mozilla.org/products/firefox/start/ and/or
http://start.mozilla.org/firefox/ to central.html or change the links in
region.properties to central.html.

Comment 7

[Rafael Ebron (:rebron)]

Hi Stephen,

Nope.  There's a Start page and then there's Firefox Central. 
http://start.mozilla.org/firefox/ is the correct url in region.properties

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Shouldn't the default start page be the same as the "central" page, for the same
reasons you gave in comment 2?

Comment 9

[Rafael Ebron (:rebron)]

Keep the start page url as is so we can redirect to the appropriate page and for
l10n purposes, etc.  

Comment 10

[Rafael Ebron (:rebron)]

Keep the start page url as is so we can control server-side and redirect to the
appropriate page for l10n purposes, etc.  

    

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Is this going to be able to make RC1?

Comment 12

[Asa Dotzler [:asa]]

this doesn't have to make RC1. 

Comment 13

[:Gavin Sharp [email: [e-mail]]]

*** Bug 266223 has been marked as a duplicate of this bug. ***

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Shouldn't some of the urls in
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser-region/region.properties
be corrected? Why is the start page and the default home page different?
http://start.mozilla.org/firefox/ and
http://www.mozilla.org/products/firefox/start/ redirect to the same place, but
the second one uses javascript, which is not the best way of doing it (bug
266223). Shouldn't http://start.mozilla.org/firefox/ redirect to the
central.html file and replace http://www.mozilla.org/products/firefox/start/ ?

Comment 15

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Please finalize the links by the end of tomorrow (end of friday) so that this
can go in.

Comment 16

[Rafael Ebron (:rebron)]

a) For both the Getting Started link on the Bookmarks toolbar and the "Firefox
Home" link in the "Firefox and Mozilla Links" Folder 
the url is: http://www.mozilla.org/products/firefox/central.html

b) The other url we need is the new one for Live bookmarks which will be a
mozilla.org url.  Will get that for you tomorrow.

c) Vlad, you're not talking about Bug 266457 and getting those links finalized too?

Comment 17

[:Gavin Sharp [email: [e-mail]]]

What about the two different start page URLs, mentioned in comment 14? Should
they just stay the same for now? If this can be sorted out I'll make an
all-encompassing patch.

Comment 18

[Rafael Ebron (:rebron)]

Yeah.  Don't change anything in region.properties.  That's fine.

Comment 19

[:Gavin Sharp [email: [e-mail]]]

In that case, the current patch is what's wanted.

Comment 20

[Steffen Wilberg]

Ben changed the throbber url in bug 266530 to central.html.
But we still have two different start pages in region.properties:
homePageDefault              =http://www.mozilla.org/products/firefox/start/
startup.homepage_override_url=http://www.mozilla.org/products/firefox/start/
browser.startup.homepage     =http://start.mozilla.org/firefox/

Shouldn't we change the first two to start.m.o?

And shouldn't http://www.mozilla.org/products/firefox/start/ redirect to
http://start.mozilla.org/firefox/ instead of the product page? And it really
shouldn't say "Firefox 0.8 - Welcome!" if you disable JavaScript. I can easily
fix that if you want.

Comment 21

[Rafael Ebron (:rebron)]

File a separate bug for region.properties.  Check this patch in and close out
this bug.  

Comment 22

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #21)
> File a separate bug for region.properties.

Bug 266774

Comment 23

[:Gavin Sharp [email: [e-mail]]]

Ben fixed half of this (the "Firefox Home" link) with bug 266457 comment 11. If
that is sufficient, this can be closed.

Comment 24

[Rafael Ebron (:rebron)]

Hi Vlad or Gavin,

Let's get the second half of this bug checked in: Getting Started to point to
firefox/central.html

Comment 25

[:Gavin Sharp [email: [e-mail]]]

Attachment: 2nd half

Comment 26

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 164203 [details] [diff] [review]
2nd half

Carrying over review

Comment 27

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Bookmarks component = code (not default bookmarks); punting this bug to General

Comment 28

[Rafael Ebron (:rebron)]

reassigning to Ben. Chatted with him about this.  Simple fix just need to check
it in.

Comment 29

[:Gavin Sharp [email: [e-mail]]]

It just needs a checkin. While he's at it, can bug 266954 also be checked in?
They are two blockers with simple patches that both have review.

Comment 30

[Tracy Walker [:tracy]]

verified Windows FF build 2004-11-04-06-0.11

Comment 31

[Tracy Walker [:tracy]]

really marking verified Windows FF build 2004-11-04-06-0.11