Closed Bug 266000 Opened 20 years ago Closed 20 years ago

Bookmarks toolbar folder links to firefox product page

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: axel, Assigned: bugs)

References

(
URL
)

Details

(Keywords: fixed-aviary1.0, Whiteboard: need ETA to be 11/1)

Attachments

(1 file, 1 obsolete file)

2nd half
2.68 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
What happens with the link in the toolbar bookmarks folder? The en-US version 
still links to http://www.mozilla.org/products/firefox/index.html, not sure if 
that's intentional. I recall Bart saying that that should point to 
http://www.mozilla.org/products/firefox/central.html, but that may be just me.
What version are you using currently?
Hi Vlad,

Simple fix in bookmarks.html.  If you could change "Firefox Home"
http://www.mozilla.org/products/firefox/index.html

to point to: 
http://www.mozilla.org/products/firefox/central.html

The difference between the pages is the former page is more "marketing" and
"download me" based.

The latter page is, here's what you can do with Firefox. 
Getting Started lnk on the personal toolbar should also point to this page:
/products/firefox/central.html versus index.html
Flags: blocking-aviary1.0?
Attached patch Two liner (obsolete) — — Splinter Review 
Patch as requested.
Attachment #163400 - Flags: review?(vladimir)
Comment on attachment 163400 [details] [diff] [review]
Two liner

r=vladimir
Attachment #163400 - Flags: review?(vladimir) → review+
That's not exactly this bug, but we link to a couple of start pages here:
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser-region/region.properties

We may want to redirect http://www.mozilla.org/products/firefox/start/ and/or
http://start.mozilla.org/firefox/ to central.html or change the links in
region.properties to central.html.
Hi Stephen,

Nope.  There's a Start page and then there's Firefox Central. 
http://start.mozilla.org/firefox/ is the correct url in region.properties
Shouldn't the default start page be the same as the "central" page, for the same
reasons you gave in comment 2?
Keep the start page url as is so we can redirect to the appropriate page and for
l10n purposes, etc.  
Keep the start page url as is so we can control server-side and redirect to the
appropriate page for l10n purposes, etc.  

    
Is this going to be able to make RC1?
this doesn't have to make RC1.
Flags: blocking-aviary1.0? → blocking-aviary1.0+
*** Bug 266223 has been marked as a duplicate of this bug. ***
Shouldn't some of the urls in
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser-region/region.properties
be corrected? Why is the start page and the default home page different?
http://start.mozilla.org/firefox/ and
http://www.mozilla.org/products/firefox/start/ redirect to the same place, but
the second one uses javascript, which is not the best way of doing it (bug
266223). Shouldn't http://start.mozilla.org/firefox/ redirect to the
central.html file and replace http://www.mozilla.org/products/firefox/start/ ?
Whiteboard: need ETA to be 11/1
Please finalize the links by the end of tomorrow (end of friday) so that this
can go in.
a) For both the Getting Started link on the Bookmarks toolbar and the "Firefox
Home" link in the "Firefox and Mozilla Links" Folder 
the url is: http://www.mozilla.org/products/firefox/central.html

b) The other url we need is the new one for Live bookmarks which will be a
mozilla.org url.  Will get that for you tomorrow.

c) Vlad, you're not talking about Bug 266457 and getting those links finalized too?
What about the two different start page URLs, mentioned in comment 14? Should
they just stay the same for now? If this can be sorted out I'll make an
all-encompassing patch.
Yeah.  Don't change anything in region.properties.  That's fine.
In that case, the current patch is what's wanted.
Ben changed the throbber url in bug 266530 to central.html.
But we still have two different start pages in region.properties:
homePageDefault              =http://www.mozilla.org/products/firefox/start/
startup.homepage_override_url=http://www.mozilla.org/products/firefox/start/
browser.startup.homepage     =http://start.mozilla.org/firefox/

Shouldn't we change the first two to start.m.o?

And shouldn't http://www.mozilla.org/products/firefox/start/ redirect to
http://start.mozilla.org/firefox/ instead of the product page? And it really
shouldn't say "Firefox 0.8 - Welcome!" if you disable JavaScript. I can easily
fix that if you want.
File a separate bug for region.properties.  Check this patch in and close out
this bug.  
(In reply to comment #21)
> File a separate bug for region.properties.

Bug 266774


Ben fixed half of this (the "Firefox Home" link) with bug 266457 comment 11. If
that is sufficient, this can be closed.
Hi Vlad or Gavin,

Let's get the second half of this bug checked in: Getting Started to point to
firefox/central.html
Attachment #163400 - Attachment is obsolete: true
Attachment #163400 - Flags: approval-aviary?
Comment on attachment 164203 [details] [diff] [review]
2nd half

Carrying over review
Attachment #164203 - Flags: review+
Attachment #164203 - Flags: approval-aviary?
Bookmarks component = code (not default bookmarks); punting this bug to General
Assignee: vladimir → firefox
Component: Bookmarks → General
QA Contact: mconnor → firefox.general
reassigning to Ben. Chatted with him about this.  Simple fix just need to check
it in.
Assignee: firefox → bugs
It just needs a checkin. While he's at it, can bug 266954 also be checked in?
They are two blockers with simple patches that both have review.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Keywords: fixed-aviary1.0
verified Windows FF build 2004-11-04-06-0.11
really marking verified Windows FF build 2004-11-04-06-0.11
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: