Closed Bug 266021 Opened 20 years ago Closed 20 years ago

l10n zh-CN Fix Amazon plug-in, remove yahoo

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
1.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: rebron, Assigned: shaohua.wen)

References

(
URL
)

Details

Attachments

(1 file, 5 obsolete files)

patch for searchplugins.
5.54 KB, patch
axel
: approval-aviary+
Details | Diff | Splinter Review 
/locales/zh-CN/searchplugins/amazondotcom.src
Change:
<input name="tag" value="kurona-20">
to: 
<input name="tag" value="mozilla-20">
There is a report that the yahoo plugin should be removed.
Assignee: p_ch → piaip
Flags: blocking-aviary1.0-L10N+
Summary: l10n zh-CN Fix Amazon plug-in → l10n zh-CN Fix Amazon plug-in, remove yahoo
wrong assignee, sorry. yikes, I should know better than that.
Assignee: piaip → Shaohua.Wen
OK,changed in my local machine,
Can I commit it directly or I should wait for bsmedberg to approve it?
Status: NEW → ASSIGNED
We need a patch. Please attach the patch, created with &#10;cvs -z3 diff -uN&#10;in your searchengines directory and make sure that it shows all changes.&#10;That is, cvs remove the yahoo plugin and it's image first.&#10;Then edit the attachement and set the approval-aviary1.0 flag to ?.&#10;After getting approval, you can check in. Your check in message should mention&#10;the bug number, the kind of change and who gave you approval, likely a=axel.&#10;Or a=bsmedberg, if he's faster than me.
Attached patch patch for amazondotcom.src (obsolete) — — Splinter Review 

    
  
Flags: blocking-aviary1.0-L10N+ → blocking-aviary1.0-L10N?

    
    

    
  
Hi,Axel Hecht  
  Thanks for your help!
  Could you please approve my bug#269358  and bug#269383 also?


    
  

        Attachment #165687 -
        Flags: approval-aviary?

    
  
Flags: blocking-aviary1.0-L10N? → blocking-aviary1.0-L10N+

    
    

    
  


  
Dear Alex,Is this patch what you wanted?

        Attachment #165687 -
        Attachment is obsolete: true

    
  

        Attachment #165703 -
        Flags: approval-aviary?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for searchplugins. (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #165703 -
        Attachment is obsolete: true

    
  

        Attachment #165706 -
        Flags: approval-aviary?

    
    

    
  
Comment on attachment 165706 [details] [diff] [review]
patch for searchplugins.

Rafael, please check your review queue. Shaohua checked the yahoo plugin and
reports it's working.&#10;&#10;Shaohua, please don't check this in until you
got the review from Rafael.

        Attachment #165706 -
        Flags: review?(rebron)

        Attachment #165706 -
        Flags: approval-aviary?

        Attachment #165706 -
        Flags: approval-aviary+

    
  

        Attachment #165687 -
        Flags: approval-aviary?

    
  

        Attachment #165703 -
        Flags: approval-aviary?

    
    

    
  
*** Bug 269358 has been marked as a duplicate of this bug. ***

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for searchplugins. (obsolete)
        — 
          — Splinter Review
      

    


  
OK,new patch. (with our yahoo or yahoo localized search plugin.)
As Rafael mentioned in bug#269358 that we should remove the yahoo plugin
entirely not localized.

        Attachment #165706 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 165715 [details] [diff] [review]
patch for searchplugins.

Hi Axel,Please approve this new patch.
Thanks!

        Attachment #165715 -
        Flags: approval-aviary?

    
    

    
  
Comment on attachment 165706 [details] [diff] [review]
patch for searchplugins.

rafael minused this one

        Attachment #165706 -
        Flags: review?(rebron)

        Attachment #165706 -
        Flags: review-

        Attachment #165706 -
        Flags: approval-aviary-

        Attachment #165706 -
        Flags: approval-aviary+

    
    

    
  
Comment on attachment 165715 [details] [diff] [review]
patch for searchplugins.

DANG, screw me.
Sorry for this, really.

The patches all lacked the changes to list.txt.
Be of good faith, the rest looks fine.

        Attachment #165715 -
        Flags: approval-aviary? → approval-aviary-

    
    

    
  


  

        Attachment #165715 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #165832 -
        Attachment is obsolete: true

    
  

        Attachment #165833 -
        Flags: approval-aviary?

    
    

    
  
Comment on attachment 165833 [details] [diff] [review]
patch for searchplugins.

sorry for the lengthy process, this is ok with me.

        Attachment #165833 -
        Flags: approval-aviary? → approval-aviary+

    
    

    
  
Hi Axel,
  It's OK.Thank you very much!
  I checked in the changes already.
Best Regards,Holy
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 266650 has been marked as a duplicate of this bug. ***

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: