266027 - Unable to Import data from Netscape 4.x

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Scott MacGregor]

In Thunderbird, if you do Tools / Import / Mail Settings / Communicator 4.x, the
dialog just hangs and we fail to import your 4.x mail data.

This is because the mailnews import module uses the old profile service to
generate a list of 4.x profile sources that can be migrated. This new code isn't
available in the new profile APIs that thunderbird uses so we fail to get
nsIProfileInternal and we failt to do anything useful.

cc'ing Benjamin in case he has ideas on how to fix this too.

Here's the line in question that fails:
http://lxr.mozilla.org/seamonkey/source/mailnews/import/comm4x/src/nsComm4xProfile.cpp#73

Comment 1

[Benjamin Smedberg]

http://lxr.mozilla.org/aviarybranch/source/browser/components/migration/src/nsDogbertProfileMigrator.cpp#287
may help.

Comment 2

[Scott MacGregor]

Attachment: the fix

Comment 3

[Scott MacGregor]

Comment on attachment 163373 [details] [diff] [review]
the fix

Thanks for the tip Benjamin. That helped.

David, this just copies and pastes some code from the old profile manager (I'm
sure you can guess which parts came from that) and from the new migration code
which knows how to do some of this stuff as well).

I could have #ifdef'ed this MOZ_THUNDERBIRD and left the old profile code alone
for the suite but I thought it was better to not fork the code and just have
both of us manually look for old 4.x profiles.

Comment 4

[Scott MacGregor]

fixed on the trunk now too.

Comment 5

[Scott MacGregor]

I bet I only fixed this for the settings case and it's still there for address
book or mail folders!

Comment 6

[Scott MacGregor]

*** Bug 253527 has been marked as a duplicate of this bug. ***