266047 - Clean Up button is not included in DM WIndow's tab-order

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect, P1)

Description

[Asaf Romano (gone)]

Clean Up button is not in DM Window's tab-order.

even worse when it comes to platforms that don't support accesskeys (i.e. mac),
there is no keyboard-way to trigger the CleanUp action.

Comment 1

[Asaf Romano (gone)]

Actually, Keyboard navigation.

Comment 2

[Asaf Romano (gone)]

You really shoudn't do things like this, Kevin ;)

For Winstripe:
 24 #cleanUpButton {
 25   margin: 0px;
 26   -moz-user-focus: ignore;
 27   list-style-image: url("chrome://mozapps/skin/downloads/downloadCleanup.png");
 28 }

From Pinstripe: 
 21 #cleanUpButton, #optionsButton {
 22  -moz-appearance: none;
 23  min-width: 32px;
 24  height: 26px;
 25  margin: 2px;
 26   -moz-user-focus: ignore;
 27 } 

Comment 3

[Kevin Gerich]

fixed on trunk

Comment 4

[Asaf Romano (gone)]

err, you have only fixed pinstripe, not winstripe.

Comment 5

[Asaf Romano (gone)]

Attachment: patch for winstripe

also removing unused rule (the options button has been removed).

Comment 6

[Kevin Gerich]

Comment on attachment 173569 [details] [diff] [review]
patch for winstripe

thanks mano

Comment 7

[Asaf Romano (gone)]

Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.5; previous revision: 1.4
done

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381