266066 - After moving message to junk folder, next message is not highlighted

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041025 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041025 Firefox/1.0

In recent branch builds including 20041025, moving a message to the junk folder
no longer causes the next message (the message below it, or if there isn't one,
the last message) in the window to be highlighted.

Occurs in both POP3 and IMAP accounts.


Reproducible: Always
Steps to Reproduce:
1. Configure junk mail so that when a message is marked as junk it is moved to
the Junk folder.
2. Mark a message as junk.
Actual Results:  
Message is moved to junk folder, no message is highlighted

Expected Results:  
Message should be moved to junk folder, and the message below where it was (or
the last message if there were none below it) should be highlighted.

Comment 1

[Mike Cowperthwaite]

Confirming.  Reproduced with 
  version 0.8+ (20041028)   Win2K

Symptom occurs whether using the J key/toolbutton/menu *or* when clicking in the 
Junk column for the message.

Focus is *on* the thread pane, but no message is selected; pressing down-arrow 
selects the top item in the pane.

As noted in bug 265746 comment 2:
> If there is more than 1 message highlighted, then it does select the next
> message [when 'J' or equivalent action is pressed]

Comment 2

[Scott MacGregor]

Mike, do you think this was a recent regression or something that has never worked?

Comment 3

[Scott MacGregor]

Moving into 0.9. Sounds like this is a very recent regression...

Comment 4

[Scott MacGregor]

gNextMessageViewIndexAfterDelete is getting set correctly before we do the delete.
But by the time HandleDeleteOrMoveMsgCompleted is getting called, someone has
reset gNextMessageViewIndexAfterDelete back to -2 so we don't end up doing anything.

Comment 5

[Scott MacGregor]

Interesting, OnMsgLoaded is getting called while we delete the message and that
of course clears gNextMessageViewIndexAfterDelete back to -2. 

Comment 6

[Scott MacGregor]

Attachment: the fix

whenever you marked a loaded messag as junk or not junk, we were always
reloading the message even if we were supposed to move it to trash or a junk
folder. This message reload was killing the index of the next message to load
when it finished loading so we wouldn't load the next message.

Comment 7

[Scott MacGregor]

fixed branch and trunk

Comment 8

[Mike Cowperthwaite]

Verified fixed with version 0.8+ (20041029).

I had hoped this fix would happen to also fix bug 209748 as a side effect, but 
'twas not to be.

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

This caused
{{
Warning: variable folder hides argument
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2112, Column: 14
Source Code:
          var folder = GetLoadedMsgFolder();
}}

Should the variable be renamed,
or removed as using the function parameter instead would be appropriate ?