Closed
Bug 266098
Opened 21 years ago
Closed 21 years ago
XForms comment fixes
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: bryner)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
14.31 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
A couple of classes need comments, and some need cosmetic changes.
| Reporter | ||
Comment 1•21 years ago
|
||
| Reporter | ||
Updated•21 years ago
|
Attachment #163403 -
Flags: review?(bryner)
| Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 163403 [details] [diff] [review]
Fixes for comments
>--- ../xforms.orig/nsXFormsInstanceElement.h 2004-10-26 10:32:29.197789736 +0200
>+++ ./nsXFormsInstanceElement.h 2004-10-26 10:45:27.990395264 +0200
>+/**
>+ * Implementation of the XForms <instance> element.
I don't really like using the entity names for < and > here. It's somewhat
hard to read when I look at it in my editor, and lxr doesn't have a problem
with the angle brackets either.
Seems fine otherwise.
| Reporter | ||
Comment 3•21 years ago
|
||
I agree. How about using \< and \> instead. This patch does.
Attachment #163403 -
Attachment is obsolete: true
| Reporter | ||
Updated•21 years ago
|
Attachment #163403 -
Flags: review?(bryner)
| Reporter | ||
Updated•21 years ago
|
Attachment #163547 -
Flags: review?(bryner)
| Assignee | ||
Updated•21 years ago
|
Attachment #163547 -
Flags: review?(bryner) → review+
| Assignee | ||
Comment 4•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•