266137 - Cross checks missing in sanitycheck

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Bugzilla 2.19

Several newly introduced cross references are missing in sanitycheck.cgi.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Let sanitycheck know about newer Bugzilla tables [trunk patch]

Comment 2

[Dave Miller [:justdave]]

oof.

A bunch of those tables exist in 2.18 also (but not all).  Suppose it would be
possible to get this backported to 2.18, too?

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Let sanitycheck know about newer Bugzilla tables [branch patch]

(In reply to comment #2)
> Suppose it would be possible to get this backported to 2.18, too?

Makes sense to me to port it back.

Comment 4

[Vlad Dascalu]

Comment on attachment 163436 [details] [diff] [review]
Let sanitycheck know about newer Bugzilla tables [trunk patch]

+	    # ['series', 'creator'], # Generated series get user id 0

By reading sanitycheck.cgi I found a comment for sub CrossCheck that mentions:

#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#	 fields should use NULL instead - see bug #109474.

So I guess we could add 0 there (and plan in the future to use NULL instead or
something like that). I see this is done below:

	    ["components", "initialqacontact", "name", ["0"]]);

I assume we need something like that as well.

Comment 5

[Vlad Dascalu]

Comment on attachment 163542 [details] [diff] [review]
Let sanitycheck know about newer Bugzilla tables [branch patch]

Same here.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Patch v1.2 [trunk]

Allowing 0 for user ID in series table

Comment 7

[Marc Schumann [:Wurblzap]]

Attachment: Patch v1.2 [branch]

Comment 8

[Vlad Dascalu]

Comment on attachment 168217 [details] [diff] [review]
Patch v1.2 [trunk]

+	    ["bugs_activity", "fieldid"],
+	    ['profiles_activity', 'fieldid']);

Looks inconsistent to use both ' and ". We should choose one and go for it. I
think this can be done upon check in though, and it's more of a nit. Not
blocking my review. :)

Otherwise looks good to go.

Comment 9

[Vlad Dascalu]

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.72.2.1; previous revision: 1.72
done

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.73; previous revision: 1.72
done