266149 - [trunk] Installer fails (xpcom_core.dll not found)

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Bill Mason]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041025 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041026 Firefox/0.9.1+

The install cannot complete.  The error "The dynamic link library xpcom_core.dll
could not be found in the specified path" (followed by my system's path) occurs
and the install hangs.

Reproducible: Always
Steps to Reproduce:
1.



Works in the 2004102507 build.
Broken in the 2004102607 build.

Comment 1

[Bill Mason]

Tried in on a WinXP system, got an error 'Could not load xpistub.dll' and the
installer hangs again.

Comment 2

[Matthew Darwin]

Confirm this on Windows 2000, using FirefoxSetup.exe  from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
build date: 26-Oct-2004 10:51 

Comment 3

[Robert M. Jackson]

  This problem also arises installing the latest Mozilla build [Mozilla/5.0
(Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041026].  However, it
appears that the installation really only stalls when it is trying to launch
Mozilla after putting the files in place.  The unfound file does appear at
C:\Program Files\Common Files\mozilla.org\GRE\1.8a5_2004102604\xpcom_core.dll
but Mozilla does not find it.  Placing a copy of this file in the Mozilla
program folder ends the problem.  (Note if relevant that my copy of the Mozilla
program is not in the default location.)  Suggests an issue with where the file
is placed or where Mozilla expects it?

Comment 4

[Bill Mason]

(In reply to comment #3)
>   This problem also arises installing the latest Mozilla build [Mozilla/5.0
> (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041026].

Bug 266214 opened for that.

Comment 5

[Darin Fisher]

-> me

Comment 6

[Darin Fisher]

FYI, my fix for bug 266214 should not help here.

Comment 7

[Darin Fisher]

Attachment: v1 patch

This patch should fix the problem.  I somehow forgot to add a line for
xpcom_core.dll to the static build packaging manifest :-(

I went ahead and applied this fix to the trunk to hopefully make tomorrow's
builds work properly.

Comment 8

[Darin Fisher]

marking FIXED

Comment 9

[Bill Mason]

Fix is good, 2004102708 PC/Win2000