266185 - English & localized build system IDs can collide, possible symbol confusion

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Chase Phillips]

The English and localized build systems run in parallel but only push symbols
from releases made at different hours of the day.  If an English Windows
Tinderbox were to run a release build at the same time as a localized Windows
Tinderbox, a collision could occur, causing the post-mozilla process for one of
the builds to fail (since the build ID is already registered with the Talkback
server) or worse, the symbols for the later build could overwrite the earlier
build's symbols.  If we knew this had occurred, we could take steps by hand to
correct the situation.  If not, we may end up receiving correct Talkback data
for one build and incorrect data for another build.

This issue isn't critical but it is the device that puts the bullet in the gun
for when we could shoot ourselves in the foot, process-wise.  I'd like to take a
proactive approach to this, if at all possible.

I agree with Jon that creating a separate product for the localized builds would
diverge the builds more than needed.  Is there a way to update the build ID so
that the Talkback server receives '<date>-l10n' from the localized build
systems?  This would require at least two changes: 1) Ensuring the Talkback
server can handle generic strings as build IDs; and 2) Configuring the localized
Tinderboxen to append -l10n to the build_number/build ID created during the
build of the software.

Comment 1

[Jay Patel [:jay]]

The best solution is to append a letter or short string to the end of the build
id.  I do not recommend using anything other than letters in the build id
string, as we have not thoroughly tested the Talkback server for such ids.  

I do remember adding "trnk" to special build ids in the past without seeing any
problems, so I suggest we simply add the letter "l" to the end of the build id
(e.g. 2004102608l) for localized builds.  That will minimize problems with the
Talkback reporting scripts and keep things simple.

Comment 2

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 3

[Benjamin Smedberg]

We now repackage the en-US builds into localized builds, so this isn't an issue.