If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove (some) #ifdefs from GTK classic

RESOLVED FIXED

Status

SeaMonkey
Themes
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Ginn Chen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.81 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
As per bug 251492 it may be possible to remove the #ifdefs from
classic/global/unix/checkbox.css and radio.css and classic/global/win/menu.css -
so far I only tried checkbox.css and I don't see any regressions.
(Assignee)

Comment 1

13 years ago
Created attachment 163548 [details] [diff] [review]
patch

patch to remove #ifdefs in classic/global/unix/checkbox.css, radio.css
and some #ifdefs in classic/global/win/menu.css.
Not tested yet.

I think we could not remove all the #ifdefs in classic/global/win/menu.css yet.
(Assignee)

Updated

13 years ago
Attachment #163548 - Flags: review?(neil.parkwaycc.co.uk)
(Reporter)

Comment 2

13 years ago
Comment on attachment 163548 [details] [diff] [review]
patch

radio.css and checkbox.css look fine to me with GTK1 although I haven't had a
chance to test the changes to menu.css yet.
(Assignee)

Updated

13 years ago
Attachment #163548 - Attachment is obsolete: true
Attachment #163548 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 3

13 years ago
Created attachment 174942 [details] [diff] [review]
patch v2

revised and tested on Fedora Core 3 gtk build
Attachment #174942 - Flags: review?(neil.parkwaycc.co.uk)
(Reporter)

Updated

13 years ago
Attachment #174942 - Flags: superreview+
Attachment #174942 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #174942 - Flags: review+
(Assignee)

Comment 4

13 years ago
Checking in themes/classic/jar.mn;
/cvsroot/mozilla/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.129; previous revision: 1.128
done
Checking in themes/classic/global/unix/checkbox.css;
/cvsroot/mozilla/themes/classic/global/unix/checkbox.css,v  <--  checkbox.css
new revision: 1.14; previous revision: 1.13
done
Checking in themes/classic/global/unix/radio.css;
/cvsroot/mozilla/themes/classic/global/unix/radio.css,v  <--  radio.css
new revision: 1.13; previous revision: 1.12
done
Checking in themes/classic/global/win/menu.css;
/cvsroot/mozilla/themes/classic/global/win/menu.css,v  <--  menu.css
new revision: 1.56; previous revision: 1.55
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.