266286 - EdImageOverlay.js has hacks around (fixed) bug 198435

Status: NEW

(SeaMonkey :: Composer, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The code has a workaround bug 198435, which has been fixed for a while.  It
should be safe to remove the workaround.

Comment 1

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 2

[Stefan [:stefanh]]

EdImageOverlay.js still contain hacks around bug 198435. The file even contains this comment at line 377:
"XXXbz that bug is long-since fixed.  Is this still needed?"

Comment 3

[Phoenix]

Attachment: Hack removal

Something like this?

Comment 4

[[e-mail]]

Comment on attachment 642534 [details] [diff] [review]
Hack removal

No, the hack is that we create a new image each time.

(In fact, we don't even need to create an HTML image any more, since XUL images now size to fit correctly. See bug 773821 for example.)