nsIAlertsService should use AString instead of wstring

RESOLVED FIXED in mozilla1.8alpha6

Status

SeaMonkey
General
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Assigned: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com])

Tracking

Trunk
mozilla1.8alpha6
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee: general → cst
Whiteboard: active
Product: Browser → Seamonkey
Attachment #167950 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #167950 - Flags: review?(scott)
Whiteboard: active → active, r?
Attachment #167950 - Flags: review?(scott) → review?(mscott)
Attachment #167950 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview?(jag)

Comment 2

13 years ago
Do we use nsAString for URIs? Or nsACString? Or should we just switch to a
nsIURI there? Or would that be overkill?

Comment 3

13 years ago
It gets passed to JavaScript to set as an attribute on a XUL element.
(Ideally it would be the class attribute rather than the src, but...)
I believe JavaScript would prefer to find a UTF-16 string here.

Updated

13 years ago
Attachment #167950 - Flags: review?(mscott) → review+
Target Milestone: --- → mozilla1.8alpha6
Status: NEW → ASSIGNED

Comment 4

13 years ago
Comment on attachment 167950 [details] [diff] [review]
Patch

The very long line you made in nsMessengerWinIntegration looks as if it should
be rewrapped.
Attachment #167950 - Flags: superreview?(jag) → superreview+
Whiteboard: active, r? → checkin
Whiteboard: checkin → checkin [re-wrap before checkin]
checked in...

(In reply to comment #4)
> (From update of attachment 167950 [details] [diff] [review] [edit])
> The very long line you made in nsMessengerWinIntegration looks as if it should
> be rewrapped.

...and checked in again (sorry).
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: checkin [re-wrap before checkin]
You need to log in before you can comment on or make changes to this bug.