Closed Bug 266289 Opened 20 years ago Closed 20 years ago

nsIAlertsService should use AString instead of wstring

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha6

People

(Reporter: csthomas, Assigned: csthomas)

Details

Attachments

(1 file)

Patch
8.24 KB, patch
mscott
: review+
neil
: superreview+
Details | Diff | Splinter Review
Assignee: general → cst
Product: Browser → Seamonkey
Attachment #167950 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #167950 - Flags: review?(scott)
Whiteboard: active → active, r?
Attachment #167950 - Flags: review?(scott) → review?(mscott)
Attachment #167950 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview?(jag)
Do we use nsAString for URIs? Or nsACString? Or should we just switch to a
nsIURI there? Or would that be overkill?
It gets passed to JavaScript to set as an attribute on a XUL element.
(Ideally it would be the class attribute rather than the src, but...)
I believe JavaScript would prefer to find a UTF-16 string here.
Attachment #167950 - Flags: review?(mscott) → review+
Target Milestone: --- → mozilla1.8alpha6
Status: NEW → ASSIGNED
Comment on attachment 167950 [details] [diff] [review]
Patch

The very long line you made in nsMessengerWinIntegration looks as if it should
be rewrapped.
Attachment #167950 - Flags: superreview?(jag) → superreview+
Whiteboard: active, r? → checkin
Whiteboard: checkin → checkin [re-wrap before checkin]
checked in...

(In reply to comment #4)
> (From update of attachment 167950 [details] [diff] [review] [edit])
> The very long line you made in nsMessengerWinIntegration looks as if it should
> be rewrapped.

...and checked in again (sorry).
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: checkin [re-wrap before checkin]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: