266329 - preference issues in Italian build

Status: RESOLVED FIXED

(Mozilla Localizations :: it / Italian, defect)

Description

[sairuh (rarely reading bugmail)]

found using the 2004-10-27-0.11 firefox-1.0.it-IT.linux-i686.tar.gz on Linux
FC2. please reassign as needed, esp if this is the wrong place.

1. decompress build, launch firefox with a new profile.

2. go into the Preferences dialog

observe: the category and panel labels for Privacy and Downloads are still in
English. (I compared with today's Spanish l10n build, and those labels are
correctly in Spanish.)

3. in the General panel, click the Languages (Lingua) button.

observe: the Languages and Character Encoding dialog doesn't have any Languages
in the listbox --it's empty. (eg, in English and Spanish builds, there are
choices for English and Spanish listed there, respectively.)

Comment 1

[Michele Dal Corso]

What did you see in the Privacy panel?
Something like this screenshot? 
http://dalcorso.it/m/privacy-panel-itIT.png

The Privacy, Cache and Cookie words hasn't translation in Italian and they are
used as is.

Comment 2

[Michele Dal Corso]

> 3. in the General panel, click the Languages (Lingua) button.
> 
> observe: the Languages and Character Encoding dialog doesn't have any Languages
> in the listbox --it's empty. (eg, in English and Spanish builds, there are
> choices for English and Spanish listed there, respectively.)

I found the problem: the file firefox-l10n.js has this setting:
pref("intl.accept_languages", "it-IT, it");
that doesn't work. I changed to:
pref("intl.accept_languages", "it");
and now the Languages panel correctly report the it accepted language.

Comment 3

[Benjamin Smedberg]

I did *not* approve this change, and the tree is closed. Why are you checking
stuff in?

Comment 4

[sairuh (rarely reading bugmail)]

(In reply to comment #1)
> What did you see in the Privacy panel?
> Something like this screenshot? 

Michele, yes that's what I saw.

Comment 5

[Michele Dal Corso]

(In reply to comment #3)
> I did *not* approve this change, and the tree is closed. Why are you checking
> stuff in?

I saw only this morning in l10n newsgroup your post that every change need to be
approved.
The pref("intl.accept_languages", "it-IT, it"); preference isn't interpreted by
Firefox, instead pref("intl.accept_languages", "it"); yes.

I will try to generate a patch for this.

Comment 6

[Michele Dal Corso]

Attachment: Patch to firefox-l10n.js

I made this patch to correct the intl.accept_languages error.

Comment 7

[Michele Dal Corso]

Because I did not undestand the new rules for l10n updates, I already checked in
the cvs this patch and in the latest italian builds this issue seems ok.

I mailed to Benjamin to correct the problem, but I did not get a reply.

So I assume this bug is fixed.

Comment 8

[Benjamin Smedberg]

Actually, this change is incorrect. You shouldn't need *any* pref here, since
the default pref is already localized. I apologize for some confusion I caused
about this in the newsgroups. The correct place to change this pref is

http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/it-IT/chrome/global/intl.properties#3

And I think the setting you have is fine. I have removed the extra line in
firefox-l10n.js as it is unneeded and probably harmful.