266331 - "Page has no feeds for Live Bookmark" in tooltip when page is loading

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Daniel Vijge]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

When a page with live bookmarks is loading the live bookmark icon is displayed
in the right lower corner but the tooltip reads "Page has no feed for Live
Bookmark". As soon as the page complets loading the correct tooltip appears

Reproducible: Always
Steps to Reproduce:
1. Go to a page with live bookmarks, such as http://www.mozillazine.org
2. Hold mouse over live bookmark icon while page is loading

Actual Results:  
Tooltips says "Page has no feeds for Live Bookmark"

Expected Results:  
Tooltip should say "Add Live Bookmark for this page's feed"

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We don't know that the page has live bookmarks until the page finishes loading.
 Nothing we can do.

Comment 2

[Phil Ringnalda (:philor)]

Sorry to reopen on you, but you need a slower connection to see these things ;)

DOMLinkAdded fires and calls livemarkOnLinkAdded,  and if it's a livemark link
we add it to browser.livemarkLinks and if it's the current browser we set
livemark-button.livemarks to true, and the icon shows at that point, and can
already be used, but the tooltip doesn't change until load fires and calls
updatePageLivemarks.

Looks to me like we just need another
gLivemarksButton.setAttribute("tooltiptext",
gNavigatorBundle.getString("livemarkHasLivemarksTooltip")); in
livemarkOnLinkAdded, when it sets livemark-button.livemarks

Comment 3

[Phil Ringnalda (:philor)]

Wups, meant to confirm this at the time. And at the time, I seem to have
understood why we have a tooltip saying "nothing here" when we don't show the
icon when there's nothing there, which I now don't quite get.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: patch v1

Complete str:
1. Connect to the internet over dialup (sorry, but it's easier to saturate the
connection).
2. Start downloading something hefty, like a nightly Firefox zip.
3. Load something slow with feeds, like http://planet.mozilla.org
4. As soon as the feed icon appears in the location bar, hover over it.

The patch just sets the tooltip at the same time we set feeds="true", to cover
the time between when a feed is added and when the page loads or the user
changes tabs away and back.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: patch v.2

Unrotted.

Comment 6

[Phil Ringnalda (:philor)]

Attachment: patch v.3

Unrotted.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 198254 [details] [diff] [review]
patch v.3

r=mano

Comment 8

[Asaf Romano (gone)]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.519; previous revision: 1.518
done

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js; new revision: 1.479.2.73;

Comment 10

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.