Closed
Bug 266332
Opened 20 years ago
Closed 20 years ago
Add code to nsFrameList to detect loops
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
|
5.52 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
827 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This won't catch everything, but it'll catch people who create loops via the frame list api itself (eg adding the same frame twice). People who hand-munge linked lists can probably still create undetected loops...
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #163623 -
Flags: superreview?(roc)
Attachment #163623 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 163649 [details] [diff] [review] Assertion that caught bug 265986 r+sr=bzbarsky
Attachment #163649 -
Flags: superreview+
Attachment #163649 -
Flags: review+
Comment on attachment 163623 [details] [diff] [review] Patch nifty!
Attachment #163623 -
Flags: superreview?(roc)
Attachment #163623 -
Flags: superreview+
Attachment #163623 -
Flags: review?(roc)
Attachment #163623 -
Flags: review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Both patches checked in to trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•20 years ago
|
Target Milestone: --- → mozilla1.8alpha5
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•