Closed Bug 266332 Opened 21 years ago Closed 21 years ago

Add code to nsFrameList to detect loops

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8alpha5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

This won't catch everything, but it'll catch people who create loops via the frame list api itself (eg adding the same frame twice). People who hand-munge linked lists can probably still create undetected loops...
Attached patch PatchSplinter Review
Blocks: 265986
Attachment #163623 - Flags: superreview?(roc)
Attachment #163623 - Flags: review?(roc)
Comment on attachment 163649 [details] [diff] [review] Assertion that caught bug 265986 r+sr=bzbarsky
Attachment #163649 - Flags: superreview+
Attachment #163649 - Flags: review+
Comment on attachment 163623 [details] [diff] [review] Patch nifty!
Attachment #163623 - Flags: superreview?(roc)
Attachment #163623 - Flags: superreview+
Attachment #163623 - Flags: review?(roc)
Attachment #163623 - Flags: review+
Both patches checked in to trunk.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha5
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: