Closed Bug 266346 Opened 20 years ago Closed 20 years ago

Popups enabled while javascript alerts() are open

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jst, Assigned: jst)

References

(
URL
)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(2 files)

Testcase.
265 bytes, text/html
Details
Fix. Disable popups while DOM modal dialogs are open
2.88 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
chofmann
: approval-aviary+
chofmann
: approval1.7.5+
Details | Diff | Splinter Review 
If a page that tries to open popups is loaded in a window while an alert()
dialog is open in another window the loading page is able to open popups,
assuming the alert was opened from a click or some other action that enabled
popups. Very similar to bug 261613, but the fix for that bug didn't catch all cases.
Attached file Testcase. — 
Click the URL in this bug in one window and load this testcase in a different
window (not tab).
Assignee: general → jst
Status: NEW → ASSIGNED
Attachment #163633 - Attachment is patch: false
Attachment #163633 - Attachment mime type: text/plain → text/html
Blocking aviary per Ben's request.
Flags: blocking-aviary1.0+
Attachment #163636 - Attachment description: Fix. Disable popups while DOM modal dialogs are opened. → Fix. Disable popups while DOM modal dialogs are open
Attachment #163636 - Flags: superreview?(bzbarsky)
Attachment #163636 - Flags: review?(bzbarsky)
Comment on attachment 163636 [details] [diff] [review]
Fix. Disable popups while DOM modal dialogs are open

r+sr=bzbarsky.
Attachment #163636 - Flags: superreview?(bzbarsky)
Attachment #163636 - Flags: superreview+
Attachment #163636 - Flags: review?(bzbarsky)
Attachment #163636 - Flags: review+
Attachment #163636 - Flags: approval1.7.x?
Attachment #163636 - Flags: approval-aviary?
Fixed on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 163636 [details] [diff] [review]
Fix. Disable popups while DOM modal dialogs are open

a=chofmann for the branches
Attachment #163636 - Flags: approval1.7.x?
Attachment #163636 - Flags: approval1.7.x+
Attachment #163636 - Flags: approval-aviary?
Attachment #163636 - Flags: approval-aviary+
Fixed on branches.
Keywords: fixed-aviary1.0, fixed1.7.x
verified Windows FF build 2004-11-04-06-0.11
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: