266513 - Dependent windows don't persist the correct position

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[[e-mail]]

Dependent windows, such as the Open Location dialog, normally perist their
position relative to their parent. However since the given checkin the saved
positions are offset apparently by the size of the window decorations (on my
system, by 6 pixels horizontally and 20 vertically).

I verified that backing out that part of the patch restores the behaviour.

Comment 1

[Boris Zbarsky [:bzbarsky]]

That part of which patch?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this fixed by the change to fix the GTK1 warnings that I checked in yesterday?

Comment 3

[[e-mail]]

(In reply to comment #2)
>Is this fixed by the change to fix the GTK1 warnings that I checked in yesterday?
No it is not. However, popups no longer deactivate their parent :-)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Reverting just the putative optimization to GetWindowPos fixes the bug.

Comment 5

[[e-mail]]

Comment on attachment 164133 [details] [diff] [review]
fix

Thanks for the fix :-)

Comment 6

[[e-mail]]

/me hopes roc doesn't mind if I check this in for him ;-)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

thanks! sorry