266546 - Extension Update gets wrong version of "disable targets for download"

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Aaron Slunt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

When the update searches for an update to "Disable Targets for Download", it
says it finds one, version .7. However, when it downloads and installs, it spits
out an error saying along the lines of "Disable targets for download 0.5 cannot
be installed because it's incompatible."

Reproducible: Always
Steps to Reproduce:
1.If 0.5 is already installed, run the update for the extension.
2.Select 0.7 as the version to update to.
3.

Actual Results:  
Firefox says 0.5 can't be installed.

Expected Results:  
Downloaded and installed 0.7, like it says it would do.

I believe that this can also be a security flaw, because if Firefox is
downloading the wrong file for this, who knows what else it could potentially
download for other things.

Comment 1

[Jesse Ruderman]

Does clearing the cache fix it?

Comment 2

[Aaron Slunt]

Nope

Comment 3

[Jesse Ruderman]

Wolf, is this another result of the update.mozilla.org bug with updates that use
the same filename?

Comment 4

[Aaron Slunt]

This seems to have been fixed...

Comment 5

[Daniel Veditz [:dveditz]]

WFM per comment 4. This doesn't rate the confidential flag unless it
demonstrates a way to purposefully hack the system to force the wrong downloads
on people. If it's something only someone who could change the extension can do,
then they could just do evil things silently in the extension code itself.